Skip to content

Merge all Verify CODEOWNERS sections

Fabio Pitino requested to merge fix-verify-codeowners-section into master

What does this MR do and why?

In !118461 (merged) we split the Verify section into Verify backend, Verify frontend and CI/CD templates.

This causes a problem where for example MRs that only change frontend code require backend approval because Verify backend defines some catch-all rules like /**/app/**/ci/:

image

Most of the Verify code should be defined inside /**/ci/ paths. The reason why we want to have catch-all rules is to be aware of what file paths are not correctly owned. So by default we require backend approval from Verify maintainers but if we realize that some paths require more specific ownership we create a specific rule that overrides the catch-all rule.

The ideal approval rules for Verify is to have them all inside a single section. Having separate sections means that we have independent approval rules, while we want to be as specific as possible instead.

Merge all Verify CODEOWNERS sections

By merging all Verify related sections under a single [Verify] section we ensure that a single set of required approvals is applied.

For example: if a CI template is modified we apply the specific approval rule which overrides the catch-all rules at the top of Verify section.

We want the Verify section to be a single channel of approvals that has generic catch-all rules but also specific rules.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports