Skip to content

Fixed how series render and legend in VSA Overview "Total time" chart

What does this MR do and why?

Removes the custom summation code that was used to stack the series in the VSA Overview "Total time" chart in favor of ECharts's implementation – adding the stack property to both the nonNull and null series. This fixes the issue where the series were overlapping instead of stacking, causing the chart to take on a grayish hue.

Following this discussion, it also adjusts legend toggling so that data legend items also toggle off their corresponding null series, makes the "No data" legend purely presentational and ensures that at least one data legend item is always selected. These last two adjustments are being worked on concurrently in a gitlab-ui MR:

Screenshots or screen recordings

Stacked Area Chart Fix

Before After
Screenshot_2023-04-26_at_2.33.05_PM Screenshot_2023-04-27_at_12.48.03_PM

Legend Toggling Fix(es)

Before After
Screen_Recording_2023-05-05_at_2.43.01_PM Screen_Recording_2023-05-10_at_1.05.04_AM

How to set up and validate locally

  1. Please make sure that you're on an Ultimate plan.
  2. Visit VSA for any group or seed data if necessary.
  3. Verify that the stacked area chart appears under "Total Time" and that it works/looks as expected.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #407801 (closed)

Edited by Rudy Crespo

Merge request reports