Skip to content

Replaced Feature flag to reduce aggregation schedule lease

Suraj Tripathi requested to merge replace_ff_to_reduce_namespace_aggregator_delay into master

What does this MR do and why?

As a part of this effort we made changes to remove the NamespaceAggregator Lease all together. Over a period of time we have reduced the lease duration from 1.5hrs to 30 mins, and while trying to remove the lease completely we found some degradation in the Container Registry API, because of which we decided to reduce the lease further instead of removing the lease all together.

So as part of this MR, we are reducing the lease duration from 30 mins to 2 mins, but we cannot directly use the remove_namespace_aggregator_delay FF, which we used for 30mins because remove_namespace_aggregator_delay is already enabled for all users on production.

Changing 30mins to 2 mins directly is an unknown so we want to roll it out incrementally. So we have introduced a new FF(reduce_aggregation_schedule_lease), and removed the older feature flag(remove_namespace_aggregator_delay) which is enabled for all on production.

Have explained the same thing in the issue here

So this MR:

  1. Removed remove_namespace_aggregator_delay FF
  2. Added reduce_aggregation_schedule_lease FF
  3. Changed code/spec to reflect the same

ref: https://gitlab.com/gitlab-org/gitlab/-/issues/370251

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Suraj Tripathi

Merge request reports