Fix auto-correctable `Style/EmptyElse` Cop

What does this MR do and why?

Fixes auto-correctable RuboCop offenses for Style/EmptyElse in excludes

Some files have been left in exclude for the following reasons:

Comments in else clause:

• app/models/performance_monitoring/prometheus_dashboard.rb
• app/models/resource_state_event.rb
• app/models/resource_timebox_event.rb
• app/services/award_emojis/add_service.rb
• app/workers/post_receive.rb
• config/initializers/doorkeeper_openid_connect.rb
• ee/app/helpers/ee/kerberos_helper.rb
• ee/app/services/projects/update_mirror_service.rb
• ee/lib/elastic/latest/note_instance_proxy.rb
• ee/lib/gitlab/analytics/cycle_analytics/summary/change_failure_rate.rb
• lib/gitlab/ci/variables/collection.rb
• lib/gitlab/database/load_balancing/sidekiq_server_middleware.rb
• lib/gitlab/sidekiq_daemon/monitor.rb

Causes other Cops to throw an error and fails commit hook:

• app/controllers/concerns/sends_blob.rb
• app/controllers/google_api/authorizations_controller.rb
• app/finders/group_finder.rb
• app/graphql/resolvers/group_milestones_resolver.rb
• app/graphql/types/ci/detailed_status_type.rb
• app/models/legacy_diff_discussion.rb
• ee/app/services/gitlab_subscriptions/check_future_renewal_service.rb
• lib/gitlab/auth/o_auth/provider.rb
• lib/gitlab/database/sha256_attribute.rb
• lib/gitlab/git.rb
• lib/peek/views/external_http.rb

Screenshots or screen recordings

No visual changes

How to set up and validate locally

• Run rubocop --only Style/EmptyElse

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

• I have evaluated the MR acceptance checklist for this MR.

Related to #239356

added typemaintenance label

Hey @JonstonChan!

Thank you for your contribution to GitLab. Please refer to the contribution flow documentation for a quick overview of the process, and the merge request (MR) guidelines for the detailed process.

Did you know about our community forks? Working from there will make your contribution process easier. Please check it out!

When you're ready for a first review, post @gitlab-bot ready. If you know a relevant reviewer(s) (for example, someone that was involved in a related issue), you can also assign them directly with @gitlab-bot ready @user1 @user2.

At any time, if you need help, feel free to post @gitlab-bot help or initiate a mentor session on Discord. Read more on how to get help.

You can comment @gitlab-bot label <label1> <label2> to add labels to your MR. Please see the list of allowed labels in the label command documentation.

This message was generated automatically. You're welcome to improve it.

added Community contribution workflowin dev labels

assigned to @JonstonChan

This merge request will be counted as part of the running Hackathon!

Check out the Hackathon page for more information!

This message was generated automatically. You're welcome to improve it.

added Hackathon label

added backend label

added linked-issue label

added workflowready for review label and removed workflowin dev label

@vyaklushin, this Community contribution is ready for review.

• Do you have capacity and domain expertise to review this? We are mindful of your time, so if you are not able to take this on, please re-assign to one or more other reviewers.
• Add the workflowin dev label if the merge request needs action from the author.

This message was generated automatically. You're welcome to improve it.

requested review from @vyaklushin

added QA database databasereview pending labels

	3 Warnings
	This MR changes code in ee/, but its Changelog commit is missing the EE: true trailer. Consider adding it to your Changelog commits.
	This merge request does not refer to an existing milestone.
	Please add a merge request subtype to this merge request.

	1 Message
	This merge request adds or changes files that require a review from the Database team.

This merge request requires a database review. To make sure these changes are reviewed, take the following steps:

1. Ensure the merge request has database and databasereview pending labels. If the merge request modifies database files, Danger will do this for you.
2. Prepare your MR for database review according to the docs.
3. Assign and mention the database reviewer suggested by Reviewer Roulette.

The following files require a review from the Database team:

• app/finders/merge_requests_finder/params.rb
• app/finders/snippets_finder.rb

Reviewer roulette

Changes that require review have been detected!

Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

Category	Reviewer	Maintainer
backend	Michał Wielich (@michold) (UTC+2)	George Koltsov (@georgekoltsov) (UTC+1)
database	Tianwen Chen (@tianwenchen) (UTC+10)	Matt Kasa (@mattkasa) (UTC-7)
QA	Edgars Brālītis (@ebralitis) (UTC+3)	Maintainer review is optional for QA
groupcompliance	Reviewer review is optional for groupcompliance	Harsimar Sandhu (@harsimarsandhu) (UTC+5.5)
~"Merge Requests backend"	Reviewer review is optional for ~"Merge Requests backend"	Sincheol (David) Kim (@dskim_gitlab) (UTC+9.5)
~"group::authentication and authorization"	Reviewer review is optional for ~"group::authentication and authorization"	Jarka Košanová (@jarka) (UTC+2)

To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

changed milestone to %16.0

added maintenancerefactor label

approved this merge request

@vyaklushin, thanks for approving this merge request.

This is the first time the merge request is approved. To ensure full test coverage, please start a new pipeline before merging.

For more info, please refer to the following links:

• rspec predictive jobs
• jest predictive jobs
• merging a merge request.

added pipeline:mr-approved label

requested review from @harsimarsandhu, @dskim_gitlab, and @jarka and removed review request for @vyaklushin

Allure report

allure-report-publisher generated test report!

e2e-package-and-test: test report for 466c8f40

expand test summary

+-----------------------------------------------------------------------+
|                            suites summary                             |
+------------------+--------+--------+---------+-------+-------+--------+
|                  | passed | failed | skipped | flaky | total | result |
+------------------+--------+--------+---------+-------+-------+--------+
| Create           | 736    | 1      | 106     | 125   | 843   | ❌     |
| Data Stores      | 181    | 0      | 3       | 40    | 184   | ❗     |
| Plan             | 304    | 0      | 0       | 165   | 304   | ❗     |
| Govern           | 231    | 0      | 0       | 230   | 231   | ❗     |
| Verify           | 269    | 1      | 20      | 220   | 290   | ❌     |
| Package          | 126    | 0      | 59      | 0     | 185   | ✅     |
| Fulfillment      | 12     | 0      | 120     | 0     | 132   | ✅     |
| Release          | 30     | 0      | 0       | 20    | 30    | ❗     |
| Secure           | 35     | 0      | 25      | 35    | 60    | ❗     |
| Monitor          | 44     | 0      | 11      | 40    | 55    | ❗     |
| Manage           | 214    | 5      | 20      | 48    | 239   | ❌     |
| Systems          | 19     | 0      | 0       | 0     | 19    | ✅     |
| Analytics        | 11     | 0      | 0       | 10    | 11    | ❗     |
| GitLab Metrics   | 2      | 0      | 1       | 0     | 3     | ✅     |
| Configure        | 1      | 0      | 15      | 0     | 16    | ✅     |
| ModelOps         | 0      | 0      | 5       | 0     | 5     | ➖     |
| Growth           | 0      | 0      | 10      | 0     | 10    | ➖     |
| Framework sanity | 0      | 0      | 5       | 0     | 5     | ➖     |
+------------------+--------+--------+---------+-------+-------+--------+
| Total            | 2215   | 7      | 400     | 933   | 2622  | ❌     |
+------------------+--------+--------+---------+-------+-------+--------+

approved this merge request

removed review request for @jarka

Setting label(s) Quality based on QA.

added Quality label

approved this merge request

removed review request for @harsimarsandhu

approved this merge request

resolved all threads

I think we have all the necessary approvals so I'll set MWPS now.

enabled an automatic merge when the pipeline for 997198e5 succeeds

	1 Warning
	This MR changes code in ee/, but its Changelog commit is missing the EE: true trailer. Consider adding it to your Changelog commits.

	1 Message
	This merge request adds or changes files that require a review from the Database team.

This merge request requires a database review. To make sure these changes are reviewed, take the following steps:

1. Ensure the merge request has database and databasereview pending labels. If the merge request modifies database files, Danger will do this for you.
2. Prepare your MR for database review according to the docs.
3. Assign and mention the database reviewer suggested by Reviewer Roulette.

The following files require a review from the Database team:

• app/finders/merge_requests_finder/params.rb
• app/finders/snippets_finder.rb

Reviewer roulette

Changes that require review have been detected!

Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

Category	Reviewer	Maintainer
backend	Marcos Rocha (@mc_rocha) (UTC-4)	Vasilii Iakliushin (@vyaklushin) (UTC+2)
database	Tianwen Chen (@tianwenchen) (UTC+10)	Michał Zając (@Quintasan) (UTC+2)
QA	Will Meek (@willmeek) (UTC+1)	Maintainer review is optional for QA
groupcompliance	Reviewer review is optional for groupcompliance	Harsimar Sandhu (@harsimarsandhu) (UTC+5.5)
~"group::authentication and authorization"	Reviewer review is optional for ~"group::authentication and authorization"	Smriti Garg (@sgarg_gitlab) (UTC+5.5)
~"Merge Requests"	Reviewer review is optional for ~"Merge Requests"	Sincheol (David) Kim (@dskim_gitlab) (UTC+9.5)

To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

merged

@JonstonChan, how was your code review experience with this merge request? Please tell us how we can continue to iterate and improve:

1. React with a or a on this comment to describe your experience.
2. Create a new comment starting with @gitlab-bot feedback below, and leave any additional feedback you have for us in the comment.

Interested in learning more tips and tricks to solve your next challenge faster? Subscribe to the GitLab Community Newsletter for contributor-focused content and opportunities to level up.

Thanks for your help!

This message was generated automatically. You're welcome to improve it.

mentioned in commit b8f88dc4

added workflowstaging-canary label and removed workflowready for review label

added workflowcanary label and removed workflowstaging-canary label

added workflowstaging label and removed workflowcanary label

added workflowproduction label and removed workflowstaging label

added workflowpost-deploy-db-staging label and removed workflowproduction label

added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label

added releasedcandidate label

mentioned in merge request kubitus-project/kubitus-installer!2145 (merged)