Skip to content

Remove pre enforcement date based thresholds

Vijay Hawoldar requested to merge vij-remove-storage-dates into master

What does this MR do and why?

When we first started implementing storage limits, the initial concept was to notify users of the upcoming limits based on the current date proximity to the rollout date, and re-displaying the banner based on different date thresholds as we got closer to the limits being enforced.

With https://gitlab.com/groups/gitlab-org/-/epics/9173, this approach has changed and instead the notifications will be handled by admins via a notification_limit setting that has already been introduced. This way, the banner will be simplified to simply display or not display based on the customer's storage usage.

Therefore, this MR removes date/threshold based pre-enforcement notification logic and defers to the newly added notification_limit instead.

All of this logic is unreleased and guarded behind application settings and feature flags.

Refs https://gitlab.com/gitlab-org/gitlab/-/issues/385728, https://gitlab.com/gitlab-org/gitlab/-/issues/385725 and https://gitlab.com/gitlab-org/gitlab/-/issues/390917

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Vijay Hawoldar

Merge request reports