Skip to content

Make SSO button larger

Eduardo Sanz García requested to merge eduardosanz/make-sso-button-larger into master

What does this MR do and why?

We increase the relevance and noticeability of the SSO buttons by making them the same width as the normal GitLab Sign in button. As decided here: !116995 (comment 1358733815)

In addition, when the restyle_login_page feature flag is enabled, we remove the label Sign in with and replaced by a horizontal separator. This is inline with the overall minimalistic design of the restyle. In addition, it makes it more similar to the trial registration page.

No changes should be noticed it the restyle_login_page feature flag is disabled.

Partially addresses #386487 (closed)

Screenshots or screen recordings

With restyle_login_page enabled

Before After
image image
image image
image image

With restyle_login_page disabled (no changes).

Before After
image image
image image
image image

How to set up and validate locally

Visit:

  1. https://gdk.test:3443/users/sign_in
  2. https://gdk.test:3443/-/trial_registrations/new
  3. https://gdk.test:3443/admin/session/new (With Enable admin mode enabled. Go to Admin > Settings > General > Sign-in restrictions)

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Eduardo Sanz García

Merge request reports