Allow QE maintainers to approve QA CI changes

Mark Lapierrerequested to merge
ml-allow-quality-maintainers-to-approve-qa-ci into master

What does this MR do and why?

Code owners rules required approval from the EP team for all CI changes, including QA-related CI code (e.g.: !117957 (merged)).

This adds QE maintainers as approvers for QA CI code, so that MRs with only QA-related CI changes don't contribute unnecessarily to the EP team's workload. Ideally, we would move the rules to the End-to-end section, but that would mean the /.gitlab/ci/ rule would still require EP approval. This compromise allows either the EP team or QE maintainers to approve changes to QA-related CI code, without altering the rules for other CI code.

(An alternative would have been to use a tool to exhaustively list each CI file, and assign the EP team or others as appropriate. But that would result in a more complicated code owners file)

(Another alternative would be the ability to exclude certain files from a section. I.e., add QA CI code to a Quality section, and add an exclusion for that same code to the EP section. Unfortunately, that isn't yet possible.)

See also this Slack discussion (but it's more-or-less summarized in this description).

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Mark Lapierre

Merge request reports