Skip to content
Snippets Groups Projects

Remove show_tags_on_commits_view feature flag

Merged Jerry Seto requested to merge 397738-feature-flag-cleanup-show_tags_on_commits_view into master
All threads resolved!

What does this MR do and why?

Removes show_tags_on_commits_view feature flag. It's been default enabled since 15.10 and the feature seems stable.

How to set up and validate locally

  1. Create some commits
  2. Add tag to a commit
  3. Add multiple tags to a different commit
  4. Check the commits view (e.g http://127.0.0.1:3000/root/project/-/commits/main) and see that the tag badges appear next to the correct commits

Should look like this:

Screenshot_2023-02-08_at_3.10.35_PM

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #397738 (closed)

Edited by Jerry Seto

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Stan Hu approved this merge request

    approved this merge request

  • Stan Hu resolved all threads

    resolved all threads

  • merged

  • @stanhu, did you forget to run a pipeline before you merged this work? Based on our code review process, if the latest pipeline was created more than 6 hours ago OR finished more than 2 hours ago, you should:

    1. Ensure the merge request is not in Draft status.
    2. Start a pipeline (especially important for Community contribution merge requests).
    3. Set the merge request to merge when pipeline succeeds.

    This is a guideline, not a rule. Please consider replying to this comment for transparency.

    This message was generated automatically. You're welcome to improve it.

  • Stan Hu mentioned in commit 64ac8dba

    mentioned in commit 64ac8dba

  • added workflowstaging label and removed workflowcanary label

  • Please register or sign in to reply
    Loading