Remove show_tags_on_commits_view feature flag
What does this MR do and why?
Removes show_tags_on_commits_view
feature flag. It's been default enabled since 15.10 and the feature seems stable.
How to set up and validate locally
- Create some commits
- Add tag to a commit
- Add multiple tags to a different commit
- Check the commits view (e.g http://127.0.0.1:3000/root/project/-/commits/main) and see that the tag badges appear next to the correct commits
Should look like this:
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #397738 (closed)
Merge request reports
Activity
changed milestone to %16.0
assigned to @j.seto
- A deleted user
added backend label
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Serena Fang (
@serenafang
) (UTC-5, 1 hour behind@j.seto
)Stan Hu (
@stanhu
) (UTC-7, 3 hours behind@j.seto
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangermentioned in commit gitlab-org-sandbox/gitlab-jh-validation@329fcb7b
added 200 commits
-
1ca4e8f7...1bb808de - 199 commits from branch
master
- 7c504296 - Remove show_tags_on_commits_view feature flag
-
1ca4e8f7...1bb808de - 199 commits from branch
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@c8456cfd
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@7c8776fc
Allure report
allure-report-publisher
generated test report!e2e-package-and-test:
test report for db581e19expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Monitor | 54 | 0 | 0 | 54 | 54 | ❗ | | Data Stores | 172 | 0 | 0 | 55 | 172 | ❗ | | Plan | 307 | 0 | 0 | 161 | 307 | ❗ | | Verify | 270 | 0 | 20 | 225 | 290 | ❗ | | Manage | 166 | 0 | 15 | 75 | 181 | ❗ | | Configure | 0 | 0 | 15 | 0 | 15 | ➖ | | Govern | 232 | 0 | 0 | 232 | 232 | ❗ | | Fulfillment | 10 | 0 | 110 | 0 | 120 | ✅ | | Analytics | 10 | 0 | 0 | 10 | 10 | ❗ | | Package | 125 | 0 | 23 | 0 | 148 | ✅ | | Release | 30 | 0 | 0 | 20 | 30 | ❗ | | Secure | 20 | 0 | 40 | 20 | 60 | ❗ | | Create | 744 | 1 | 107 | 153 | 852 | ❌ | | Framework sanity | 0 | 0 | 6 | 0 | 6 | ➖ | | Growth | 0 | 0 | 10 | 0 | 10 | ➖ | | ModelOps | 0 | 0 | 5 | 0 | 5 | ➖ | | Systems | 2 | 0 | 0 | 0 | 2 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 2142 | 1 | 351 | 1005 | 2494 | ❌ | +------------------+--------+--------+---------+-------+-------+--------+
added 1 commit
- db581e19 - Remove show_tags_on_commits_view feature flag
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@b49d5b89
- Resolved by Stan Hu
hi @pedropombeiro
could you review this for backend?
requested review from @pedropombeiro
requested review from @jpcyiza and removed review request for @pedropombeiro
@jpcyiza
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
@j.seto Great work! Approved!
Hey @stanhu
, would you have time to maintainerize this?- Resolved by Stan Hu
@stanhu, did you forget to run a pipeline before you merged this work? Based on our code review process, if the latest pipeline was created more than 6 hours ago OR finished more than 2 hours ago, you should:
- Ensure the merge request is not in Draft status.
- Start a pipeline (especially important for Community contribution merge requests).
- Set the merge request to merge when pipeline succeeds.
This is a guideline, not a rule. Please consider replying to this comment for transparency.
This message was generated automatically. You're welcome to improve it.
mentioned in commit 64ac8dba
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label