Skip to content

Stop scanning ee/spec for externalized strings

Lukas 'ai-pi' Eipert requested to merge 28597-stop-scanning-ee-spec into master

What does this MR do and why?

We currently scan ee/spec for externalized strings, which brings up a few false-positives. These false positives create an unnecessary burden for translators and increase our scan time quite a bit (about 19% of our rb/erb/haml files are found inside ee/spec). On my machine this reduces the execution time from 29.4s to 21.5s when running on one core only.

Fixed two specs which used confusing placeholder names in strings.

See: #28597 (closed)

Screenshots or screen recordings

N/A

How to set up and validate locally

N/A

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #28597 (closed)

Edited by Peter Leitzen

Merge request reports