Skip to content

Removing Pipeline Activity Limit

Max Fan requested to merge 368195-remove-pipeline-activity-limit into master

What does this MR do and why?

This MR removes the pipeline activity limit that was never used or enforced on Gitlab.com

It removes the following.

  1. The backend processing for pipeline activity limits.
  2. The UI/Frontend used to show this limit.
  3. The REST API attribute used to set this limit
  4. Documentation about this limit

Note: This will not be a breaking change for Gitlab.com as it was never used. But could be a breaking change for self-managed users. The impact is still low as only instance admins can set/view this limit. And for self-managed there's a very small chance they even want this limit as it'll impact their workflow. Either way, there are alternatives suggested in the deprecation notice and it's a small change to switch to these alternatives.

Deprecation notice was sent out in 15.3: !92705 (merged)

This change is not FF - see following logic: #368195 (comment 1357956744)

Screenshots or screen recordings

Differences in Gitlab Help:

Compare: https://gitlab.com/help/instance_configuration

Local: image

Differences in the Admin panel:

Local: image

The "Maximum number of active pipelines per project" is gone

How to set up and validate locally

  1. Ensure gitlab works as usual. As this limit was never used and never enforced it's hard to test

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #368195 (closed)

Edited by Max Fan

Merge request reports