Skip to content

Upgrade omniauth-saml to 2.1.0

Jessie Young requested to merge jy-omniauth-saml into master

What does this MR do and why?

Screenshots or screen recordings

After clicking "Verify SAML Configuration": Screenshot_2023-04-18_at_3.15.50_PM

How to set up and validate locally

  1. Confirm that instance SAML still works
    1. Set up instance SAML: https://gitlab.com/gitlab-org/gitlab-development-kit/-/blob/main/doc/howto/saml.md#instance-saml-with-docker
    2. Confirm that sign up / sign in via SAML still works
  2. Confirm that group SAML still works
    1. Set up group SAML: https://gitlab.com/gitlab-org/gitlab-development-kit/-/blob/main/doc/howto/saml.md#group-saml
    2. Confirm that sign up / sign in via Group SAML still works (using GitLab single sign-on URL available via https://gdk.test:3443/groups/#GROUP_NAME/-/saml)
  3. Confirm that group admin can "Verify SAML Configuration"
    1. Visit https://gdk.test:3443/groups/#GROUP_NAME/-/saml as a group admin after group SAML is configured
    2. Click "Verify SAML Configuration" button
    3. There should be a "SAML Response Output" section on the page that shows that the configuration is valid. Example of what this looks like

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Jessie Young

Merge request reports