Skip to content

GraphQL: Change runner.projects default sort

Pedro Pombeiro (OOO from July 16th till Aug 7th) requested to merge pedropombeiro/372117/remove-default-sort-order into master

What does this MR do and why?

This MR removed the default sort order from the CiRunner.projects resolver. It now uses the default id_desc sort order. The behavior was deprecated in %15.4.

Closes #372117 (closed)

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. Go to the shell in your GDK gitlab directory and run bundle exec rake 'gitlab:seed:runner_fleet[root, rf5-, 10, 400]'. This will seed your GDK with some projects and runners required for testing this MR.

  2. Go to http://gdk.test:3000/-/graphql-explorer and execute the following query:

    {
  project(
    fullPath: "rf5-top-level-group-1/rf5-group-1.1/rf5-group-1.1.1/rf5-project-1-1-1-1"
  ) {
    runners(type: PROJECT_TYPE) {
      nodes {
        id
        projectCount
        projects(search: "rf5-", searchNamespaces: false) {
          nodes {
            id
            fullPath
            namespace {
              fullName
            }
          }
        }
      }
    }
  }
}

  3. In the list of projects, look for a runner which has multiple projects. The projects should be listed in descending order in this branch, compared with ascending order in master.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Stan Hu

Merge request reports