Skip to content

Adjust layout of mr widget checkboxes

Dan Mizzi-Harris requested to merge danmh-fix-mr-widget-checkbox-spacing into master

What does this MR do and why?

Describe in detail what your merge request does and why.

This MR resets some alignment issues in the 'ready to merge' MR widget caused by gitlab-ui fixes upstream (gitlab-ui!3364 (merged)).

I've also made the spacing between checkboxes match Pajamas.

ITK thread on slack.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After
Screenshot_2023-04-18_at_17.16.45 Screenshot_2023-04-18_at_17.15.15
Screenshot_2023-04-18_at_17.16.52 Screenshot_2023-04-18_at_17.15.24

For reference, here is how the widget used to look before the upstream changes broke the layout here. Notice the change to the spacing between items.

Before before This MR
Screenshot_2023-04-18_at_17.01.44 Screenshot_2023-04-18_at_17.15.15
Screenshot_2023-04-18_at_17.02.05 Screenshot_2023-04-18_at_17.15.24

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. Create an MR that you have the correct permissions to merge. For example, create a new file called text.txt
  2. View the MR widgets.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Dan Mizzi-Harris

Merge request reports