Skip to content

Fix page "jump" when sorting is changed for VSA stage tables

Dannyel Cardoso da Fonseca requested to merge dannyelcf/gitlab:364844-dcf-page-jump-when-sorting-is-changed-for-VSA-stage-tables into master

What does this MR do and why?

This MR fixes the page "jump" when sorting is changed for VSA stage tables.

Example:

sorting_jump

Link to a Value Stream Analytics page with such problem

https://gitlab.com/gitlab-org/gitlab/-/value_stream_analytics?created_after=2023-03-14&created_before=2023-04-12&stage_id=12588&value_stream_id=3115&sort=duration&direction=asc&page=1

Screenshots or screen recordings

After the fix:

  • No more "jumps" when sorting VSA stage tables
  • Smooth scroll to top of table after navigating through its pages (prev/next buttons)

Recording_2023-04-13_at_23.32.23

How to set up and validate locally

  1. Run GitLab (gdk start)
  2. Go to a Value Stream Analytics page of a project. Menu Analytics >> Value stream

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #364844 (closed)

Edited by Dannyel Cardoso da Fonseca

Merge request reports