Skip to content

Remove max width restriction from state loader

Savas Vedova requested to merge 405149-mr-fix-loading-state into master

What does this MR do and why?

Remove max width restriction from state loader. The max-width seems not to be used and causes the following regression: #405149 (closed)

Screenshots or screen recordings

before after
image image

How to set up and validate locally

  1. Fork https://gitlab.com/gitlab-examples/security/security-reports/
  2. Create an MR
  3. Apply the following patch:
diff --git a/app/assets/javascripts/vue_merge_request_widget/components/extensions/base.vue b/app/assets/javascripts/vue_merge_request_widget/components/extensions/base.vue
index e07afcb7420a..07f393913b71 100644
--- a/app/assets/javascripts/vue_merge_request_widget/components/extensions/base.vue
+++ b/app/assets/javascripts/vue_merge_request_widget/components/extensions/base.vue
@@ -61,6 +61,7 @@ export default {
       return this.$options.i18n?.error || __('Failed to load');
     },
     isLoadingSummary() {
+      return true;
       return this.loadingState === LOADING_STATES.collapsedLoading;
     },
     isLoadingExpanded() {

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #405149 (closed)

Edited by Savas Vedova

Merge request reports