Skip to content

Remove grace period for BackgroundMigration/MissingDictionaryFile cop

Prabakaran Murugesan requested to merge 395354-remove-grace-period-for-bm-missing-dictionary-file into master

What does this MR do and why?

!110743 (merged) introduced BackgroundMigration/MissingDictionaryFile cop with a grace period, this MR removes the grace period since there are no new violations in #f_rubocop for the last few weeks.

How to set up and validate locally

  • Commands to check the grace_period? of the cop 
      require_relative 'rubocop/formatter/graceful_formatter'
  
  config = RuboCop::ConfigStore.new.for_pwd
  cop_config = config.for_cop('BackgroundMigration/MissingDictionaryFile')
  RuboCop::Formatter::GracefulFormatter.grace_period?('BackgroundMigration/MissingDictionaryFile', cop_config)
  • Running the above commands in the rails console with and without this MR changes should result in 'true' and 'false' respectively.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Closes #395354 (closed)

Edited by Prabakaran Murugesan

Merge request reports