Cleanup the detect_android_projects
What does this MR do and why?
This issue is to cleanup the detect_android_projects
feature flag. As per @eugielimpin
Unfortunately, this experiment was never turned on.
And we have no plans to turn this experiment on in the near future. We should remove all related code.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #398664 (closed)
Merge request reports
Activity
changed milestone to %Backlog
assigned to @syarynovskyi
- A deleted user
added backend label
1 Warning 4d0740a0: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Michael Becker (
@wandering_person
) (UTC+7, 4 hours ahead of@syarynovskyi
)Charlie Ablett (
@cablett
) (UTC+12, 9 hours ahead of@syarynovskyi
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangermarked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
- Resolved by Kamil Trzciński
Hi @eugielimpin
Since you implemented this feature, could you pls take a first look?
requested review from @eugielimpin
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@3158bab6
added workflowin review label and removed workflowin dev label
Allure report
allure-report-publisher
generated test report!e2e-package-and-test:
test report for 4d0740a0expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Manage | 166 | 0 | 15 | 75 | 181 | ❗ | | Govern | 232 | 0 | 0 | 232 | 232 | ❗ | | Create | 739 | 0 | 106 | 153 | 845 | ❗ | | Plan | 307 | 0 | 0 | 161 | 307 | ❗ | | Release | 30 | 0 | 0 | 20 | 30 | ❗ | | Framework sanity | 0 | 0 | 6 | 0 | 6 | ➖ | | Data Stores | 172 | 0 | 0 | 55 | 172 | ❗ | | ModelOps | 0 | 0 | 5 | 0 | 5 | ➖ | | Package | 125 | 0 | 23 | 0 | 148 | ✅ | | Verify | 270 | 0 | 20 | 225 | 290 | ❗ | | Fulfillment | 10 | 0 | 110 | 0 | 120 | ✅ | | Monitor | 54 | 0 | 0 | 54 | 54 | ❗ | | Secure | 35 | 0 | 25 | 35 | 60 | ❗ | | Configure | 0 | 0 | 15 | 0 | 15 | ➖ | | Analytics | 10 | 0 | 0 | 10 | 10 | ❗ | | Systems | 2 | 0 | 0 | 0 | 2 | ✅ | | Growth | 0 | 0 | 10 | 0 | 10 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 2152 | 0 | 335 | 1020 | 2487 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+
- Resolved by Eugie Limpin
removed review request for @eugielimpin
requested review from @eugielimpin
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@54599d0a
@eugielimpin
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@e50a48f8
requested review from @ayufan
added maintenanceremoval typemaintenance labels and removed typefeature label
removed featureaddition label
removed review request for @eugielimpin
changed milestone to %15.11
- Resolved by Kamil Trzciński
removed review request for @ayufan
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@1b1342d9
requested review from @ayufan
added 1390 commits
-
9a4f2836...5880a3af - 1387 commits from branch
master
- c7dd2327 - Cleanup the detect_android_projects
- ed52448b - Return ios condition back
- 4d0740a0 - Pass detector service explicitly
Toggle commit list-
9a4f2836...5880a3af - 1387 commits from branch
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@e654add2
Thanks @syarynovskyi @eugielimpin LGTM
enabled an automatic merge when the pipeline for 70fdb522 succeeds
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@70fdb522
mentioned in commit 4f193014
added workflowstaging-canary label and removed workflowin review label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!2145 (merged)