Skip to content
Snippets Groups Projects

Fix Memory Report links

Merged Aleksei Lipniagov requested to merge 352726-fix-memory-report-link into master

What does this MR do and why?

Fixes Memory Report link/button in the Performance Bar:

  • The link is now unique for every request selected from the dropdown
  • We only render the link for GET requests

Screenshots or screen recordings

Screenshot_2023-04-06_at_17.42.12

How to set up and validate locally

Open Performance Bar locally.
Select some GET requests from the dropdown in the right part.
Click Memory Report.

On master:

  • The link is always the same and renders the report the for the window URL (main request)
  • The link is available for POST requests but does not make any sense (we don't replay POST requests)

On this branch:

  • The link is unique for every request selected from the dropdown
  • We only render the link for GET requests

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #352726 (closed)

Edited by Aleksei Lipniagov

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Contributor

    Bundle size analysis [beta]

    This compares changes in bundle size for entry points between the commits ad763ee0 and f4e58828

    :sparkles: Special assets

    Entrypoint / Name Size before Size after Diff Diff in percent
    average 3.62 MB 3.62 MB - 0.0 %
    mainChunk 2.08 MB 2.08 MB - 0.0 %

    Note: We do not have exact data for ad763ee0. So we have used data from: 3e47f6ef.
    The intended commit has no webpack pipeline, so we chose the last commit with one before it.

    Please look at the full report for more details


    Read more about how this report works.

    Generated by :no_entry_sign: Danger

  • Contributor

    Allure report

    allure-report-publisher generated test report!

    e2e-review-qa: :white_check_mark: test report for f4e58828

    expand test summary
    +-----------------------------------------------------------------------+
    |                            suites summary                             |
    +------------------+--------+--------+---------+-------+-------+--------+
    |                  | passed | failed | skipped | flaky | total | result |
    +------------------+--------+--------+---------+-------+-------+--------+
    | Govern           | 26     | 0      | 0       | 0     | 26    | ✅     |
    | Plan             | 49     | 0      | 1       | 0     | 50    | ✅     |
    | Create           | 28     | 0      | 1       | 0     | 29    | ✅     |
    | Verify           | 10     | 0      | 0       | 0     | 10    | ✅     |
    | Manage           | 8      | 0      | 3       | 0     | 11    | ✅     |
    | Data Stores      | 22     | 0      | 0       | 0     | 22    | ✅     |
    | Framework sanity | 9      | 0      | 1       | 0     | 10    | ✅     |
    | Monitor          | 4      | 0      | 0       | 0     | 4     | ✅     |
    | Package          | 0      | 0      | 1       | 0     | 1     | ➖     |
    +------------------+--------+--------+---------+-------+-------+--------+
    | Total            | 156    | 0      | 7       | 0     | 163   | ✅     |
    +------------------+--------+--------+---------+-------+-------+--------+
  • Aleksei Lipniagov added 388 commits

    added 388 commits

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • Aleksei Lipniagov marked this merge request as ready

    marked this merge request as ready

  • added 1 commit

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • added 1 commit

    • 1871cdf3 - Refactor PerfBar method naming

    Compare with previous version

  • added 1 commit

    • 34cbeaaa - Refactor PerfBar method naming

    Compare with previous version

  • Aleksei Lipniagov requested review from @rzwambag

    requested review from @rzwambag

  • Aleksei Lipniagov marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed

    marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed

  • Aleksei Lipniagov requested review from @leipert

    requested review from @leipert

  • Roy Zwambag approved this merge request

    approved this merge request

  • Roy Zwambag removed review request for @rzwambag

    removed review request for @rzwambag

  • :wave: @rzwambag, thanks for approving this merge request.

    This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.

    For more info, please refer to the following links:

  • added 1 commit

    • ec3b73df - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • Aleksei Lipniagov requested review from @robyrne

    requested review from @robyrne

  • Ross Byrne
  • added 1 commit

    • f1e3b511 - Use memoryReportPath as computed

    Compare with previous version

  • Ross Byrne approved this merge request

    approved this merge request

  • Aleksei Lipniagov removed review request for @leipert and @robyrne

    removed review request for @leipert and @robyrne

  • Aleksei Lipniagov requested review from @rzwambag

    requested review from @rzwambag

  • Ross Byrne requested review from @anna_vovchenko

    requested review from @anna_vovchenko

  • Aleksei Lipniagov removed review request for @rzwambag

    removed review request for @rzwambag

  • Anna Vovchenko removed review request for @anna_vovchenko

    removed review request for @anna_vovchenko

  • added 1 commit

    • f4e58828 - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • requested review from @anna_vovchenko

  • Anna Vovchenko approved this merge request

    approved this merge request

  • Anna Vovchenko resolved all threads

    resolved all threads

  • Anna Vovchenko changed milestone to %15.11

    changed milestone to %15.11

  • Anna Vovchenko enabled an automatic merge when the pipeline for aa21306d succeeds

    enabled an automatic merge when the pipeline for aa21306d succeeds

  • merged

  • Anna Vovchenko mentioned in commit 74f8f3b1

    mentioned in commit 74f8f3b1

  • added workflowstaging label and removed workflowcanary label

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading