Fix Memory Report links
What does this MR do and why?
Fixes Memory Report
link/button in the Performance Bar:
- The link is now unique for every request selected from the dropdown
- We only render the link for GET requests
Screenshots or screen recordings
How to set up and validate locally
Open Performance Bar locally.
Select some GET requests from the dropdown in the right part.
Click Memory Report
.
On master
:
- The link is always the same and renders the report the for the window URL (main request)
- The link is available for POST requests but does not make any sense (we don't replay POST requests)
On this branch:
- The link is unique for every request selected from the dropdown
- We only render the link for GET requests
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #352726 (closed)
Merge request reports
Activity
changed milestone to %Backlog
assigned to @alipniagov
- A deleted user
added frontend label
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend Lukas Eipert (
@leipert
) (UTC+2, same timezone as@alipniagov
)Anna Vovchenko (
@anna_vovchenko
) (UTC+3, 1 hour ahead of@alipniagov
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangeradded maintenanceworkflow label
- Resolved by Anna Vovchenko
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits ad763ee0 and f4e58828
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.62 MB 3.62 MB - 0.0 % mainChunk 2.08 MB 2.08 MB - 0.0 %
Note: We do not have exact data for ad763ee0. So we have used data from: 3e47f6ef.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerAllure report
allure-report-publisher
generated test report!e2e-review-qa:
test report for f4e58828expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Govern | 26 | 0 | 0 | 0 | 26 | ✅ | | Plan | 49 | 0 | 1 | 0 | 50 | ✅ | | Create | 28 | 0 | 1 | 0 | 29 | ✅ | | Verify | 10 | 0 | 0 | 0 | 10 | ✅ | | Manage | 8 | 0 | 3 | 0 | 11 | ✅ | | Data Stores | 22 | 0 | 0 | 0 | 22 | ✅ | | Framework sanity | 9 | 0 | 1 | 0 | 10 | ✅ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 156 | 0 | 7 | 0 | 163 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+
added 388 commits
-
7e349d28...2d5bf38e - 387 commits from branch
master
- 2c91dfc0 - Fix Memory Report links
-
7e349d28...2d5bf38e - 387 commits from branch
requested review from @rzwambag
- Resolved by Anna Vovchenko
@rzwambag Could you please review the conceptual naming and so on?
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
- Resolved by Anna Vovchenko
requested review from @leipert
- Resolved by Anna Vovchenko
- Resolved by Aleksei Lipniagov
removed review request for @rzwambag
@rzwambag
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
requested review from @robyrne
- Resolved by Ross Byrne
requested review from @rzwambag
requested review from @anna_vovchenko
removed review request for @rzwambag
- Resolved by Aleksei Lipniagov
removed review request for @anna_vovchenko
requested review from @anna_vovchenko
changed milestone to %15.11
enabled an automatic merge when the pipeline for aa21306d succeeds
mentioned in commit 74f8f3b1
added workflowstaging-canary label and removed workflowin review label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label