Skip to content

Fix Memory Report links

Aleksei Lipniagov requested to merge 352726-fix-memory-report-link into master

What does this MR do and why?

Fixes Memory Report link/button in the Performance Bar:

  • The link is now unique for every request selected from the dropdown
  • We only render the link for GET requests

Screenshots or screen recordings

Screenshot_2023-04-06_at_17.42.12

How to set up and validate locally

Open Performance Bar locally.
Select some GET requests from the dropdown in the right part.
Click Memory Report.

On master:

  • The link is always the same and renders the report the for the window URL (main request)
  • The link is available for POST requests but does not make any sense (we don't replay POST requests)

On this branch:

  • The link is unique for every request selected from the dropdown
  • We only render the link for GET requests

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #352726 (closed)

Edited by Aleksei Lipniagov

Merge request reports