Fix: mr approvers alignment
What does this MR do and why?
This MR fixes the approvers alignment issue.
I found that the alignment in the approvers section looked weird, so I did some investigation:
The avatars were set to 24px
with the attribute img-size="24"
, but there was extra 5px(2 padding top + 3 unknown) to the parent container div
when the container is set to display: inline-block
. When we change the display
to inline-flex
, the extra 3px
will be removed, then we remove the extra pt-1
to get rid of the 2px
padding top, now the elements were properly aligned.
We also have a solution which is to set font-size: 0; line-height: 0
for a container contains no texts, the result will be the same but I'd prefer the first solution.
/cc @mtan-gitlab @orozot
Describe in detail what your merge request does and why.
Screenshots or screen recordings
Before | After |
---|---|
![]() |
![]() |
![]() |
![]() |
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
How to set up and validate locally
- Open any MR with merge approvers.
- Zoom in to 200% and inspect the elements.
- Observe.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
added JiHu contribution label
Hey @JeremyWuuuuu!
Thank you for your contribution to GitLab. Please refer to the contribution flow documentation for a quick overview of the process, and the merge request (MR) guidelines for the detailed process.
When you're ready for a first review, post
@gitlab-bot ready
. If you know a relevant reviewer(s) (for example, someone that was involved in a related issue), you can also assign them directly with@gitlab-bot ready @user1 @user2
.At any time, if you need help, feel free to post
@gitlab-bot help
or initiate a mentor session on Discord. Read more on how to get help.You can comment
@gitlab-bot label <label1> <label2>
to add labels to your MR. Please see the list of allowed labels in thelabel
command documentation.This message was generated automatically. You're welcome to improve it.
added Community contribution workflowin dev labels
assigned to @JeremyWuuuuu
5 Warnings This merge request does not refer to an existing milestone. You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the maintenancepipelines, maintenancerefactor, maintenanceworkflow, documentation, QA labels.Please add a merge request subtype to this merge request. Please add a merge request type to this merge request. This Merge Request needs to be labelled with frontend, typebug. Please request a reviewer or maintainer to add them. Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend Dheeraj Joshi (
@djadmin
) (UTC+5.5)Peter Hegman (
@peterhegman
) (UTC-7)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger@JeremyWuuuuu LGTM
- Resolved by Anna Vovchenko
@gitlab-bot ready
added workflowready for review label and removed workflowin dev label
@leetickett-gitlab
, this Community contribution is ready for review.- Do you have capacity and domain expertise to review this? We are mindful of your time, so if you are not able to take this on, please re-assign to one or more other reviewers.
- Add the workflowin dev label if the merge request needs action from the author. This message was generated automatically. You're welcome to improve it.
requested review from @leetickett-gitlab
mentioned in issue gitlab-org/quality/triage-reports#11922 (closed)
added featureenhancement groupproduct planning typefeature labels
added devopsplan sectiondev labels
changed milestone to %15.11
added bugux frontend typebug labels and removed typefeature label
removed featureenhancement label
- Resolved by Anna Vovchenko
Sorry for the delay @JeremyWuuuuu - it's been a 4 day bank holiday - i'm trying to take a look now - thanks for your patience
requested review from @anna_vovchenko and removed review request for @leetickett-gitlab
Thanks for your work, @JeremyWuuuuu! The change looks good to me, approving
- Resolved by Anna Vovchenko
@anna_vovchenko
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, please start a new pipeline before merging.
For more info, please refer to the following links:
added pipeline:mr-approved label
- Resolved by Costel Maxim
@anna_vovchenko
, thanks for approving this merge request.This is the first time the merge request has been approved. Please wait for AppSec approval before merging.
cc @gitlab-com/gl-security/appsec this is a JiHu contribution, please follow the JiHu contribution review process.
1 Warning You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the maintenancepipelines, maintenancerefactor, maintenanceworkflow, documentation, QA labels.Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend Tomáš Bulva (
@tbulva
) (UTC+2)Peter Hegman (
@peterhegman
) (UTC-7)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangeradded sec-planningcomplete label
enabled an automatic merge when the pipeline for fe7c646b succeeds
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits b3d71e67 and a05f0eb5
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.62 MB 3.62 MB - 0.0 % mainChunk 2.08 MB 2.08 MB - 0.0 %
Note: We do not have exact data for b3d71e67. So we have used data from: f825d52e.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun thebundle-size-review
job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerAllure report
allure-report-publisher
generated test report!e2e-review-qa:
test report for a05f0eb5expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Plan | 49 | 0 | 1 | 0 | 50 | ✅ | | Framework sanity | 9 | 0 | 1 | 0 | 10 | ✅ | | Create | 28 | 0 | 1 | 0 | 29 | ✅ | | Govern | 26 | 0 | 0 | 0 | 26 | ✅ | | Manage | 8 | 0 | 3 | 0 | 11 | ✅ | | Data Stores | 22 | 0 | 0 | 0 | 22 | ✅ | | Verify | 10 | 0 | 0 | 0 | 10 | ✅ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 156 | 0 | 7 | 0 | 163 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+
@JeremyWuuuuu, how was your code review experience with this merge request? Please tell us how we can continue to iterate and improve:
- React with a
or a on this comment to describe your experience. - Create a new comment starting with
@gitlab-bot feedback
below, and leave any additional feedback you have for us in the comment.
Interested in learning more tips and tricks to solve your next challenge faster? Subscribe to the GitLab Community Newsletter for contributor-focused content and opportunities to level up.
Thanks for your help!
This message was generated automatically. You're welcome to improve it.
- React with a
mentioned in commit c0692ac9
added workflowstaging-canary label and removed workflowready for review label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
mentioned in issue gitlab-jh/status-reports#216
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!2061 (merged)
- Resolved by Paul Gascou-Vaillancourt
mentioned in merge request !118516 (merged)
mentioned in issue jh-upstream-report#75 (closed)
mentioned in issue jh-upstream-report#75 (closed)