Skip to content

Cleanup RubyMine warnings when running Inspect Code

Chad Woolley requested to merge caw-cleanup-inspect-code-warnings into remote_dev

What does this MR do and why?

Add necessary noinspection errors to get a clean Inspect Code run under RubyMine for Remote Development code.

Keeping this clean makes it easier to have immediate visual feedback (green check in top right of RubyMine editor) when there are various linter errors, rather than having to wait to find it out from LeftHook on push or from CI failing.

Here is the current RubyMine custom scope definition I am using to run this:

file[gitlab]:ee/lib/remote_development//*||file[gitlab]:ee/spec/factories/remote_development//*||file[gitlab]:ee/spec/lib/remote_development//*||file[gitlab]:ee/app/services/remote_development//*||file[gitlab]:app/models/remote_development//*||file[gitlab]:ee/app/graphql/mutations/remote_development//*||file[gitlab]:ee/app/graphql/resolvers/remote_development//*||file[gitlab]:ee/app/graphql/types/remote_development//*||file[gitlab]:ee/app/models/remote_development//*||file[gitlab]:ee/spec/graphql/types/remote_development//*||file[gitlab]:ee/spec/models/remote_development//*||file[gitlab]:ee/spec/services/remote_development//*

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports