Skip to content

Improve dark mode on security policy page

Martin Čavoj requested to merge 371333-ux-bug-dark-mode-policy-page into master

What does this MR do and why?

This MR improves UX of dark mode on security policy pages (scan result policy, scan execution policy) by applying the correct background color for conditions, actions and yaml preview.

Screenshots or screen recordings

Before After (Dark) After (Light)
scan_execution_dark_before scan_execution_dark_fixed scan_execution_light_fixed
Without role-based approvers scan_result_no_role_approvers_dark_before Without role-based approvers scan_result_no_role_approvers_dark_fixed Without role-based approvers scan_result_no_role_approvers_light_fixed
With role-based approvers scan_result_role_approvers_dark_before With role-based approvers scan_result_role_approvers_dark_fixed With role-based approvers scan_result_role_approvers_light_fixed

How to set up and validate locally

  1. Enable dark mode in preferences
  2. Create new security policy (-/security/policies/new?type=scan_result_policy)
  3. Background for actions, conditions and yaml block should be visible

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #371333 (closed)

Edited by Martin Čavoj

Merge request reports