Skip to content

Global Search New Navigation - foundation

What does this MR do and why?

This is the first MR from the series of MRs seeking to add Advanced Search page support to the new navigation.

MR sequence status
1. Global Search New Navigation - fundation in review 👈 this
2. Global Search New Navigation - part 1 in review
3. Global Search New Navigation - state in review
4. Global Search New Navigation - part 2 in review
5. Global Search New Navigation - part 3 in review

Screenshots or screen recordings

old nav new nav
Screenshot_2023-04-04_at_14.30.07 Screenshot_2023-04-04_at_14.29.37

This is a technical depth MR and there will be no visual change.

How to set up and validate locally

Optional (This also works with a basic search):

  1. Setup the Advanced Search https://gitlab.com/gitlab-org/gitlab-development-kit/blob/main/doc/howto/elasticsearch.md
  2. Enable the Advanced Search http://gdk:3000/admin/application_settings/advanced_search

Setup:

  1. Enable and turn on the new left sidebar
  2. Visit the search page: http://gdk:3000/search

Validation:

  1. Toggle the Advanced Search on and off
  2. Toggle new navigation on and off
  3. Navigation states should correspond to screenshots

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #382328 (closed)

Edited by Tomas Bulva

Merge request reports