Skip to content

Remove deprecated security schemas 14.x.x

Thiago Figueiró requested to merge 366478-remove-security-report-schemas-version-14-x-x into master

What does this MR do and why?

Remove unsupported security reports schema versions 14-x-x.

DO NOT MERGE before 2023-05-11 OR until !119819 (merged) is merged.

Review notes

Reviewers probably won't be able to use Changes for a review, since this removes a tonne of schema files. I apologize in advance for the inconvenience; we have &9314 to improve the process to maintain these schemas, and I'm hoping to do it at some point for GitLab 16.x.

For reference, the relevant changes are:

  1. Remove all files in lib/gitlab/ci/parsers/security/validators/schemas/14.* and ee/lib/ee/gitlab/ci/parsers/security/validators/schemas/14.*.
  2. Add feature_category to ee/spec/lib/ee/gitlab/ci/parsers/security/validators/schema_validator_spec.rb
  3. Remove all 14.*.* versions from lib/gitlab/ci/parsers/security/validators/schema_validator.rb
  4. Update objects in spec/lib/gitlab/ci/parsers/security/validators/schema_validator_spec.rb to conform to schema 15.0.0

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #366478 (closed)

Edited by rossfuhrman

Merge request reports