Skip to content

Add String type to counter prop to remove console Vue warn message

Scott de Jonge requested to merge counter-remove-console-warn into master

What does this MR do and why?

Add String type to counter count prop to remove console Vue warn message:

[Vue warn]: Invalid prop: type check failed for prop "count". Expected Number with value 9, got String with value "9".

found in

---> <Counter> at super_sidebar/components/counter.vue
       <UserBar> at super_sidebar/components/user_bar.vue
         <SuperSidebar> at super_sidebar/components/super_sidebar.vue
           <Root>

Screenshots or screen recordings

n/a

How to set up and validate locally

  1. Enable super sidebar
    1. In rails c enabled feature flag Feature.enable(:super_sidebar_nav)
    2. Toggle on "new navigation" in user menu
  2. Add counts for MRs/Issues/To-dos
  3. View console, should be clear of any Vue warn output

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports