Skip to content

Separate out product_analytics_admin_settings

Halil Coban requested to merge 395497-separate-out-admin-settings into master

What does this MR do and why?

Separating product_analytics_admin_settings out of product_analytics_dashboards

We recently consolidated several product analytics feature flags into product_analytics_dashboards. However we need to separate out product_analytics_admin_settings.

See slack thread

With product_analytics_admin_settings enabled Screenshot_2023-03-30_at_17.01.28

With product_analytics_admin_settings disabled Screenshot_2023-03-30_at_17.02.46

How to set up and validate locally

  1. Visit http://gdk.test:3000/admin/application_settings/general
  2. You should see product analytics settings
  3. In rails console disable the product_analytics_admin_settings flag 
    Feature.disable(:product_analytics_admin_settings)
  4. Visit http://gdk.test:3000/admin/application_settings/general
  5. You should not see product analytics settings

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #395497 (closed)

Edited by Halil Coban

Merge request reports