Skip to content
Snippets Groups Projects

Add namespaces exclusion form

Merged Ammar Alakkad requested to merge 381681-namespace-exclusion-form into master
All threads resolved!

What does this MR do and why?

It adds namespace exclusion form to the namespace limits page, allowing to exclude a namespace from namespace limits/enforcement by selecting a namespace and adding a reason why it has been excluded.

Note: this MR depends on !119537 (merged) and !119737 (merged) being merged first.

Screenshots or screen recordings

before after
Screenshot_2023-05-09_at_16.47.32 Screenshot_2023-05-09_at_16.47.18

How to set up and validate locally

  • In bin/rails console run:

      Feature.enable(:namespace_limits_admin_dashboard)
      ::Gitlab::CurrentSettings.update(check_namespace_plan: true)
  • Simulate saas and restart your gdk

    $ export GITLAB_SIMULATE_SAAS=1
    $ gdk restart
  • Visit /admin/namespace_limits as root

  • Open devtools to "network" tab

  • In the form at the end of the page, select a namespace and type a reason for exclusion then submit

  • The table should change into busy state and the request should return 200

  • Try selecting the same namespace and fill the reason field and submit, you should see "400 Bad request - already excluded" error

  • Try clearing out the form and submit empty fields, you should see "You must select a namespace and add a reason for excluding it" error

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #381681

Edited by Ammar Alakkad

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Kos Palchyk
  • Kos Palchyk
  • Ammar Alakkad added 1079 commits

    added 1079 commits

    Compare with previous version

  • Ammar Alakkad added 2 commits

    added 2 commits

    • 28bf0324 - Apply review suggestions
    • 805e1dfd - Show a toast on exclusion success

    Compare with previous version

  • Ammar Alakkad added 1 commit

    added 1 commit

    • 57ecafe2 - Show a toast on exclusion success

    Compare with previous version

  • removed backend label

  • Ammar Alakkad added 2 commits

    added 2 commits

    • 03f750e5 - Apply review suggestions
    • c20d9570 - Show a toast on exclusion success

    Compare with previous version

  • Kos Palchyk approved this merge request

    approved this merge request

  • :wave: @kpalchyk, thanks for approving this merge request.

    This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.

    For more info, please refer to the following links:

  • Ammar Alakkad requested review from @iamphill

    requested review from @iamphill

  • Phil Hughes
  • Phil Hughes
  • Phil Hughes removed review request for @iamphill

    removed review request for @iamphill

  • Ammar Alakkad added 1 commit

    added 1 commit

    Compare with previous version

  • Ammar Alakkad requested review from @iamphill

    requested review from @iamphill

  • Ammar Alakkad mentioned in merge request !120986 (merged)

    mentioned in merge request !120986 (merged)

  • Phil Hughes approved this merge request

    approved this merge request

  • Phil Hughes resolved all threads

    resolved all threads

  • Phil Hughes enabled an automatic merge when the pipeline for e2e6e69b succeeds

    enabled an automatic merge when the pipeline for e2e6e69b succeeds

  • merged

  • Phil Hughes mentioned in commit 11e2a53b

    mentioned in commit 11e2a53b

  • added workflowstaging label and removed workflowcanary label

  • Please register or sign in to reply
    Loading