Add namespaces exclusion form
What does this MR do and why?
It adds namespace exclusion form to the namespace limits page, allowing to exclude a namespace from namespace limits/enforcement by selecting a namespace and adding a reason why it has been excluded.
Note: this MR depends on !119537 (merged) and !119737 (merged) being merged first.
Screenshots or screen recordings
before | after |
---|---|
![]() |
![]() |
How to set up and validate locally
-
In
bin/rails console
run:Feature.enable(:namespace_limits_admin_dashboard) ::Gitlab::CurrentSettings.update(check_namespace_plan: true)
-
Simulate saas and restart your gdk
$ export GITLAB_SIMULATE_SAAS=1 $ gdk restart
-
Visit
/admin/namespace_limits
as root -
Open devtools to "network" tab
-
In the form at the end of the page, select a namespace and type a reason for exclusion then submit
-
The table should change into busy state and the request should return 200
-
Try selecting the same namespace and fill the reason field and submit, you should see "400 Bad request - already excluded" error
-
Try clearing out the form and submit empty fields, you should see "You must select a namespace and add a reason for excluding it" error
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #381681
Merge request reports
Activity
changed milestone to %15.11
added frontend grouputilization sectionfulfillment labels
assigned to @aalakkad
added devopsfulfillment label
- Resolved by 🤖 GitLab Bot 🤖
Proper labels assigned to this merge request. Please ignore me.
@aalakkad - please see the following guidance and update this merge request.1 Error Please add typebug typefeature, or typemaintenance label to this merge request. Edited by 🤖 GitLab Bot 🤖
- A deleted user
added backend feature flag labels
6 Warnings 021c7b69: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines. 021c7b69: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.
For more information, see:
- The Handbook page on merge request types.
- The definition of done documentation.
This merge request changed files with disabled eslint rules. Please consider fixing them. You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the maintenancepipelines, maintenancerefactor, maintenanceworkflow, documentation, QA labels.This merge request changed undocumented Vue components in
vue_shared/
. Please consider creating Stories for these components:app/assets/javascripts/vue_shared/components/entity_select/entity_select.vue
1 Message CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the
Changelog
trailer to the commit message you want to add to the changelog.If you want to create a changelog entry for GitLab EE, also add the
EE: true
trailer to your commit message.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Disabled eslint rules
The following files have disabled
eslint
rules. Please consider fixing them:ee/app/assets/javascripts/pages/admin/namespace_limits/components/namespace_limits_app.vue
Run the following command for more details
node_modules/.bin/eslint --report-unused-disable-directives --no-inline-config \ 'ee/app/assets/javascripts/pages/admin/namespace_limits/components/namespace_limits_app.vue'
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend Deepika Guliani (
@deepika.guliani
) (UTC+5.5, 2.5 hours ahead of@aalakkad
)Justin Ho (
@justin_ho
) (UTC+7, 4 hours ahead of@aalakkad
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerAllure report
allure-report-publisher
generated test report!e2e-package-and-test:
test report for 46dcf00aexpand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Manage | 64 | 0 | 6 | 36 | 70 | ❗ | | Data Stores | 68 | 0 | 0 | 24 | 68 | ❗ | | Plan | 120 | 0 | 0 | 46 | 120 | ❗ | | Analytics | 4 | 0 | 0 | 4 | 4 | ❗ | | Create | 320 | 2 | 14 | 136 | 336 | ❌ | | Govern | 92 | 0 | 0 | 92 | 92 | ❗ | | Verify | 102 | 0 | 18 | 100 | 120 | ❗ | | Package | 0 | 0 | 6 | 0 | 6 | ➖ | | Secure | 14 | 0 | 10 | 14 | 24 | ❗ | | ModelOps | 0 | 0 | 2 | 0 | 2 | ➖ | | Fulfillment | 4 | 0 | 44 | 0 | 48 | ✅ | | Monitor | 16 | 0 | 0 | 16 | 16 | ❗ | | Release | 12 | 0 | 0 | 10 | 12 | ❗ | | Configure | 0 | 0 | 6 | 0 | 6 | ➖ | | Framework sanity | 0 | 0 | 2 | 0 | 2 | ➖ | | Growth | 0 | 0 | 4 | 0 | 4 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 816 | 2 | 112 | 478 | 930 | ❌ | +------------------+--------+--------+---------+-------+-------+--------+
e2e-review-qa:
test report for 021c7b69expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Plan | 49 | 0 | 1 | 0 | 50 | ✅ | | Create | 28 | 0 | 1 | 0 | 29 | ✅ | | Govern | 24 | 0 | 0 | 0 | 24 | ✅ | | Manage | 8 | 0 | 3 | 0 | 11 | ✅ | | Verify | 10 | 0 | 0 | 0 | 10 | ✅ | | Data Stores | 22 | 0 | 0 | 0 | 22 | ✅ | | Framework sanity | 9 | 0 | 1 | 0 | 10 | ✅ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 154 | 0 | 7 | 0 | 161 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+
Setting label(s) Category:Consumables Cost Management based on grouputilization.
added Category:Consumables Cost Management label
added 600 commits
-
46dcf00a...aec4eea0 - 598 commits from branch
master
- 21fe65e2 - Add frontend skeleton for plan limits
- ced792cf - Dump
-
46dcf00a...aec4eea0 - 598 commits from branch
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits e513287a and 021c7b69
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.64 MB 3.64 MB - 0.0 % mainChunk 2.08 MB 2.08 MB - 0.0 % Significant Growth: 1Expand
Entrypoint / Name Size before Size after Diff Diff in percent pages.admin.namespace_limits 18 KB 225.31 KB +207.31 KB 1151.9 %
Your MR has at least one entrypoint growing significantly (more > 1 KB or 2%). If you write new or extend existing features, this is expected and there is nothing to worry about.
Please consider pinging someone from the FE Foundations (
@leipert
,@markrian
,@ohoral
or@pgascouvaillancourt
) for review, if you are unsure about the size increase.Note: We do not have exact data for e513287a. So we have used data from: 70981116.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun thebundle-size-review
job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.Please look at the full report for more details
Read more about how this report works.
Generated by
Dangeradded 1094 commits
-
c72427d1...13219442 - 1093 commits from branch
master
- 5c226627 - Dump
-
c72427d1...13219442 - 1093 commits from branch
added typefeature label
added 1853 commits
-
5c226627...a32933f3 - 1852 commits from branch
master
- 38525d17 - Dump
-
5c226627...a32933f3 - 1852 commits from branch
changed milestone to %16.0
added missed:15.11 label
added featureaddition label
added 839 commits
-
7cac6622...fbf61779 - 838 commits from branch
master
- 021c7b69 - Dump
-
7cac6622...fbf61779 - 838 commits from branch
added 246 commits
-
021c7b69...6c20f43a - 245 commits from branch
master
- 5bb676e3 - Dump
-
021c7b69...6c20f43a - 245 commits from branch
added 389 commits
-
5bb676e3...f7fc4178 - 388 commits from branch
master
- eba0147a - Dump
-
5bb676e3...f7fc4178 - 388 commits from branch
2 Warnings 8fb785c2: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.
For more information, see:
- The Handbook page on merge request types.
- The definition of done documentation.
1 Message CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the
Changelog
trailer to the commit message you want to add to the changelog.If you want to create a changelog entry for GitLab EE, also add the
EE: true
trailer to your commit message.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend Sharmad Nachnolkar (
@snachnolkar
) (UTC+5.5, 2.5 hours ahead of@aalakkad
)Lukas Eipert (
@leipert
) (UTC+2, 1 hour behind@aalakkad
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerBundle size analysis [beta]
This compares changes in bundle size for entry points between the commits b413737f and d3cf44a1
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.02 MB 4.02 MB - 0.0 % mainChunk 2.88 MB 2.88 MB - 0.0 % Significant Growth: 1Expand
Entrypoint / Name Size before Size after Diff Diff in percent pages.admin.namespace_limits 174.08 KB 412.76 KB +238.68 KB 137.1 %
Your MR has at least one entrypoint growing significantly (more > 1 KB or 2%). If you write new or extend existing features, this is expected and there is nothing to worry about.
Please consider pinging someone from the FE Foundations (
@leipert
,@markrian
,@ohoral
or@pgascouvaillancourt
) for review, if you are unsure about the size increase.Note: We do not have exact data for b413737f. So we have used data from: 8e71b9d3.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
Dangermentioned in merge request !119537 (merged)
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
added 2276 commits
-
594489c4...5fcdc802 - 2274 commits from branch
master
- fa9dd132 - Add excluded namespaces form component
- 6ac478a9 - Use excluded_namespaces_form in excluded_namespace
-
594489c4...5fcdc802 - 2274 commits from branch
added 1 commit
- 278b9a36 - Use excluded_namespaces_form in excluded_namespace
added 1 commit
- 42126777 - Use excluded_namespaces_form in excluded_namespace
- Resolved by Phil Hughes
Hey @kpalchyk
Would you review this merge request, please?
If you're at capacity please let me know, I'll happily re-assign.
Thanks!
requested review from @kpalchyk
- Resolved by Ammar Alakkad
- Resolved by Phil Hughes
- Resolved by Kos Palchyk
- Resolved by Ammar Alakkad
- Resolved by Ammar Alakkad
- Resolved by Ammar Alakkad
- Resolved by Ammar Alakkad
added 1079 commits
-
42126777...48071ab8 - 1077 commits from branch
master
- 4d1cba22 - Add excluded namespaces form component
- 8fb785c2 - Use excluded_namespaces_form in excluded_namespace
-
42126777...48071ab8 - 1077 commits from branch
added 2 commits
- Resolved by Ammar Alakkad
- Resolved by Ammar Alakkad
removed backend label
added 2 commits
@kpalchyk
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
- Resolved by Phil Hughes
requested review from @iamphill
- Resolved by Phil Hughes
- Resolved by Phil Hughes
- Resolved by Ammar Alakkad
removed review request for @iamphill
requested review from @iamphill
mentioned in merge request !120986 (merged)
enabled an automatic merge when the pipeline for e2e6e69b succeeds
mentioned in commit 11e2a53b
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label