Clean up collector regex
What does this MR do and why?
- Removes the logic where nil collector host was handled by replacing host from
jitsu_host
- Makes
product_analytics_data_collector_host
required forproduct_analytics_application_settings_defined?
Rationale
Application settings jitsu_host
and collector_host
should be stored separately. However, as a first iteration we used to store only jitsu_host
and calculate the collector_host
based on jitsu_host
.
To make a proper fix, we
-
added a new
product_analytics_data_collector_host
toapplication_settings
table to store the above-mentioned collector host. - added a new form field for collector host. If the value is empty, we still used jitsu host to calculate a data collector host
-
backfilled nil
product_analytics_data_collector_host
in db
Now that we have everything in place, we can remove the code where we handle nil collector host.
Note: This feature is behind a feature flag and thus a changelog isn't added.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #389490 (closed)
Edited by Halil Coban