Skip to content

Add Visual Review instructions to the MR Widget

What does this MR do?

This MR covers adding the app portions for the Visual Review App MVC (see #10761 (closed) and &960 (closed)). It adds a button to the Deployment footer in the pipeline section of the MR widget, which triggers a modal containing the relevant information.

Screen_Shot_2019-04-25_at_12.10.55_PM

Screen_Shot_2019-04-25_at_12.11.04_PM

Still To Do

  • Internationalization pass for the text (I assume I need to add the strings somewhere and wrap all of them.)
  • Placing behind a feature flag
  • Figuring out what I need to do to set it as available to a certain level
  • Tests
  • Revert forcing commit

Does this MR meet the acceptance criteria?

Conformity

Performance and testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Sarah Groff Hennigh-Palermo

Merge request reports