Fix relative root on Broadcast messages
requested to merge 396368-broadcast-messages-cannot-be-set-nor-updated-on-gitlab-instances-running-with-a-relative-url into master
What does this MR do and why?
- Fixes the relative path url issue for broadcast messages as per #396368 (closed)
- Switches to use rails defined routes as the SSOT instead of recreating this as a constant in the frontend
- Adds some space between
Add broadcast messagebutton and table - Adds feature specs handling edit, create, list concepts of broadcast messages to ensure glue between backend and frontend is correct.
Screenshots or screen recordings
Relative url bug
before
after - no errors
Space between button and listing of messages
| before | after |
|---|---|
 |
 |
How to set up and validate locally
- Make your gdk operate with a relative path by setting
relative_url_rootin yourgitlab.ymlto/gitlab(from https://docs.gitlab.com/ee/install/relative_url.html#enable-relative-url-in-gitlab) and restart gdk. - visit the admin / messages area
- confirm you can create/preview/edit a broadcast message without errors. (this is the fix)
- switch branch to master and confirm there are now errors for the previous step.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #396368 (closed)
Edited by Doug Stull