Fix broken VSD link from subgroup
What does this MR do and why?
Changes in this MR
This MR ensures we:
- use the project namespace fullpath instead of path
- correctly sets the
groupPath
to include thegroups/
prefix for project VSA - pass
projectEndpoint
to the filter bar when viewing project VSA (triggers requests to the project endpoints instead of group endpoints) - updates jest tests
Summary
With Use group VSA app for licensed projects (!114056 - merged) we now render additional features for project level VSA. VSA - adding drill-up link to VSD comparison page (!112787 - merged) also adds a new link to the value stream dashboard.
This MR ensures we correctly set the path used to link to the value stream dashboard when we are viewing licensed VSA at both the project or group level:
Condition | Expected link |
---|---|
Group VSA | link to VSD for the group /groups/<group-path>/-/analytics/dashboards/value_streams_dashboard
|
Sub group VSA | link to VSD for the sub group /groups/<subgroup-path>/-/analytics/dashboards/value_streams_dashboard
|
Project VSA | link to VSD for the parent group + query for the project /groups/<group-path>/-/analytics/dashboards/value_streams_dashboard?query=project/path
|
Subgroup Project VSA | link to VSD for the sub group + query for the project /groups/<subgroup-path>/-/analytics/dashboards/value_streams_dashboard?query=project/path
|
The MR also ensures we correctly set endpoints for the filter bar at the project level
Screenshots or screen recordings
Before - subgroup project vsa | After - subgroup project vsa |
---|---|
720-before-fix-project-vsd-link | 720-trim-fix-project-vsd-link |
How to set up and validate locally
- Ensure you're on an GitLab Premium or GitLab Ultimate plan
- Enable the
group_analytics_dashboards_page
andvsa_group_and_project_parity
feature flagsFeature.enable(:group_analytics_dashboards_page) Feature.enable(:vsa_group_and_project_parity)
- Create a subgroup
- Create a new project in the subgroup
- Visit VSA for your new project project - you will see the "Create custom value stream" empty state
- Create a custom value stream for the project - note the instructions are for groups, but its the same process
The link to the value stream dashboard should appear next to the metrics after the aggregation has completed
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #382496 (closed)