Skip to content

Add sync_name check to Gitlab::Auth::Ldap::Access

What does this MR do and why?

Related to issue #11336 (closed)

Backport of !115496 (merged)

After !112427 (merged) merged, I found that it still sync ldap user name even though we set sync_name to false.

And after testing I found it still update user's profile in the method update_user_attributes in ee/lib/ee/gitlab/auth/ldap/access.rb, so I added the condition there.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

  • This MR is backporting a bug fix, documentation update, or spec fix, previously merged in the default branch.
  • The original MR has been deployed to (not applicable for documentation or spec changes).
  • This MR has a severity label assigned (if applicable).
  • Ensure the e2e:package-and-test job has either succeeded or been approved by a Software Engineer in Test.

Note to the merge request author and maintainer

The process of backporting bug fixes into stable branches is tracked as part of an internal pilot. If you have questions about this process, please:

Edited by Jay McCure

Merge request reports