Remove content-wrapper-margin class add space to layout-page
requested to merge 332705-resolve-collapsing-margin-between-layout-page-and-content-wrapper-margin into master
What does this MR do and why?
Remove .content-wrapper-margin class, use .layout-page for spacing
- Add space to compensate for performance-bar, system-header, and application header with
padding-topon.layout-page - Remove duplicate
margin-topbeing added to.content-wrapper-marginand.layout-page
Screenshots or screen recordings
Performance bar / System header / System footer
| Before | After |
|---|---|
 |
 |
Performance bar / System header
| Before | After |
|---|---|
 |
 |
System header
| Before | After |
|---|---|
 |
 |
Default
| Before | After |
|---|---|
 |
 |
How to set up and validate locally
- Inspect
.layout-pageto see padding-top for header - Add system header/footer in app settings http://127.0.0.1:3000/admin/application_settings/appearance
- Toggle performance bar p + b
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #332705 (closed)
Edited by Scott de Jonge