Skip to content

Fix bug where diff note will sometimes not create for whitespace

Phil Hughes requested to merge ph/338844/diffNoteErrorFix into master

What does this MR do and why?

This fixes a bug where sometimes a diff note will not get created when the user has whitespace setting turned off and the line they try to comment on is different when the setting is turned on.

Caveats

Whilst the diff note does get created it does not show in the diff when the setting is turned on. This is because of the differences in line hashes between the 2 versions. However the comment does get displayed on the overview tab with the diff lines so the user can at least see what line they commented on.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

#338844 (closed)

Edited by Phil Hughes

Merge request reports