Skip to content

Refactor analytics dashboards list

Jiaan Louw requested to merge 388629-refactor-dashboards-list into master

What does this MR do and why?

This MR refactors the analytics dashboard list to facilitate upcoming changes in Present call-to-actions to configure dashboards... (#388629 - closed).

The following changes are made:

  • Remove large bottom margin from dashboards list header
  • Update the helper to return an array of features instead of an obj
  • Refactor the logic in dashboards_list.vue to be more readable
  • Move the li content to a dashboard_list_item.vue component
  • Update specs where needed

Screenshots or screen recordings

Before After
image image

How to set up and validate locally

To test the product analytics dashboard items are shown, you will need to follow the instructions at https://gitlab.com/gitlab-org/gitlab/-/snippets/2474959 to enable Product Analytics on your GDK.

Visit the dashboard list at [GDK_HOST]/gitlab-org/gitlab-shell/-/analytics/dashboards/.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #388629 (closed)

Edited by Jiaan Louw

Merge request reports