Update failing QA specs on MR security widget
What does this MR do and why?
We made several changes to the MR Widget. It's currently behind the :refactor_security_extension
feature flag. Turning on causes some of the E2E specs to fail. More ref here: #361797 (comment 1323278930)
One of the reasons of the failures was the missing qa
selectors. This MR adds these selectors. Apart from that, we also changed the way data is loaded. In the previous version, the issue
, merge_request
and dismissal
feedback was included in the API call. Now, we fetch this information on demand when the modal is opened. Since E2E specs do not consider the network request, they fail. Additionally, we covered this UX on the frontend by adding a loading indicator to the modal in Frontend: Add loading state to the finding modal (#396260 - closed)
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
How to set up and validate locally
cd gitlab/qa
bundle exec bin/qa Test::Instance::All http://gdk.test:3000 -- qa/specs/features/ee/browser_ui/10_govern/create_merge_request_with_secure_spec.rb:58
bundle exec bin/qa Test::Instance::All http://gdk.test:3000 -- qa/specs/features/ee/browser_ui/10_govern/vulnerability_management_spec.rb
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
assigned to @svedova
2 Warnings This merge request does not refer to an existing milestone. This merge request contains lines with QA selectors. Please ensure e2e:package-and-test
job is run.QA Selectors
The following changed lines in this MR contain QA selectors:
- file
app/assets/javascripts/vue_merge_request_widget/components/widget/widget.vue
: -
-
data-qa-selector="expand_report_button"
-
- file
ee/app/assets/javascripts/vue_merge_request_widget/extensions/security_reports/mr_widget_security_reports.vue
: -
- data-qa-selector="vulnerability_report_grouped"
-
-
:data-qa-selector="report.qaSelector"
-
Please ensure
e2e:package-and-test
job is run and the tests are passing.For the list of known failures please refer to the latest pipeline triage issue.
If your changes are under a feature flag, please check our Testing with feature flags documentation for instructions.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend Diana Zubova (
@dzubova
) (UTC+2, same timezone as@svedova
)Peter Hegman (
@peterhegman
) (UTC-7, 9 hours behind@svedova
)QA Will Meek (
@willmeek
) (UTC+1, 1 hour behind@svedova
)Maintainer review is optional for QA To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger- file
mentioned in issue #361797 (closed)
- Resolved by Subashis ChakrabortyEdited by Savas Vedova
- Resolved by David Pisek
- Resolved by David Pisek
- Resolved by 🤖 GitLab Bot 🤖
Proper labels assigned to this merge request. Please ignore me.
@svedova - please see the following guidance and update this merge request.1 Error Please add typebug typefeature, or typemaintenance label to this merge request. Edited by 🤖 GitLab Bot 🤖
added maintenancepipelines typemaintenance labels
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 69e238e0 and 51f84d13
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.62 MB 3.62 MB - 0.0 % mainChunk 2.08 MB 2.08 MB - 0.0 %
Please look at the full report for more details
Read more about how this report works.
Generated by
DangerAllure report
allure-report-publisher
generated test report!e2e-review-qa:
test report for 51f84d13expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Data Stores | 22 | 0 | 0 | 0 | 22 | ✅ | | Plan | 49 | 0 | 1 | 0 | 50 | ✅ | | Govern | 26 | 0 | 5 | 0 | 31 | ✅ | | Create | 28 | 0 | 1 | 0 | 29 | ✅ | | Verify | 12 | 0 | 0 | 2 | 12 | ❗ | | Manage | 12 | 0 | 3 | 1 | 15 | ❗ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | | Framework sanity | 9 | 0 | 1 | 0 | 10 | ✅ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 162 | 0 | 12 | 3 | 174 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for 51f84d13expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Plan | 312 | 0 | 0 | 117 | 312 | ❗ | | Manage | 218 | 1 | 17 | 100 | 236 | ❌ | | Create | 824 | 5 | 37 | 350 | 866 | ❌ | | Growth | 0 | 0 | 10 | 0 | 10 | ➖ | | Verify | 259 | 0 | 45 | 254 | 304 | ❗ | | Govern | 235 | 0 | 0 | 234 | 235 | ❗ | | Release | 30 | 0 | 0 | 25 | 30 | ❗ | | Package | 144 | 0 | 41 | 144 | 185 | ❗ | | Data Stores | 185 | 0 | 3 | 60 | 188 | ❗ | | Fulfillment | 12 | 0 | 110 | 2 | 122 | ❗ | | Configure | 1 | 0 | 15 | 0 | 16 | ✅ | | Secure | 35 | 0 | 25 | 35 | 60 | ❗ | | Monitor | 53 | 0 | 0 | 49 | 53 | ❗ | | Analytics | 11 | 0 | 0 | 10 | 11 | ❗ | | ModelOps | 0 | 0 | 5 | 0 | 5 | ➖ | | Systems | 19 | 0 | 0 | 0 | 19 | ✅ | | GitLab Metrics | 2 | 0 | 1 | 0 | 3 | ✅ | | Framework sanity | 0 | 0 | 7 | 0 | 7 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 2340 | 6 | 316 | 1380 | 2662 | ❌ | +------------------+--------+--------+---------+-------+-------+--------+
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
- Resolved by David Pisek
mentioned in epic &8353 (closed)
assigned to @mlapierre and @willmeek and unassigned @subashis
added groupthreat insights label
added devopsgovern sectionsec labels
mentioned in epic &5629 (closed)
requested review from @dpisek
@dpisek
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
- Resolved by Will Meek
- Resolved by Will Meek
mentioned in merge request !115920 (merged)
unassigned @mlapierre
requested review from @mlapierre
enabled an automatic merge when the pipeline for b39d6195 succeeds
mentioned in commit 2735f542
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
mentioned in issue gitlab-org/quality/pipeline-triage#191 (closed)
mentioned in issue gitlab-org/quality/pipeline-triage#192 (closed)
mentioned in issue gitlab-org/quality/pipeline-triage#193 (closed)