Skip to content
Snippets Groups Projects

Update failing QA specs on MR security widget

Merged Savas Vedova requested to merge govern-fix-ee-specs into master

What does this MR do and why?

We made several changes to the MR Widget. It's currently behind the :refactor_security_extension feature flag. Turning on causes some of the E2E specs to fail. More ref here: #361797 (comment 1323278930)

One of the reasons of the failures was the missing qa selectors. This MR adds these selectors. Apart from that, we also changed the way data is loaded. In the previous version, the issue, merge_request and dismissal feedback was included in the API call. Now, we fetch this information on demand when the modal is opened. Since E2E specs do not consider the network request, they fail. Additionally, we covered this UX on the frontend by adding a loading indicator to the modal in Frontend: Add loading state to the finding modal (#396260 - closed)

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

How to set up and validate locally

  1. cd gitlab/qa
  2. bundle exec bin/qa Test::Instance::All http://gdk.test:3000 -- qa/specs/features/ee/browser_ui/10_govern/create_merge_request_with_secure_spec.rb:58
  3. bundle exec bin/qa Test::Instance::All http://gdk.test:3000 -- qa/specs/features/ee/browser_ui/10_govern/vulnerability_management_spec.rb

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Neil McCorrison

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Savas Vedova
  • Contributor

    Bundle size analysis [beta]

    This compares changes in bundle size for entry points between the commits 69e238e0 and 51f84d13

    :sparkles: Special assets

    Entrypoint / Name Size before Size after Diff Diff in percent
    average 3.62 MB 3.62 MB - 0.0 %
    mainChunk 2.08 MB 2.08 MB - 0.0 %

    Please look at the full report for more details


    Read more about how this report works.

    Generated by :no_entry_sign: Danger

  • Contributor

    Allure report

    allure-report-publisher generated test report!

    e2e-review-qa: :exclamation: test report for 51f84d13

    expand test summary
    +-----------------------------------------------------------------------+
    |                            suites summary                             |
    +------------------+--------+--------+---------+-------+-------+--------+
    |                  | passed | failed | skipped | flaky | total | result |
    +------------------+--------+--------+---------+-------+-------+--------+
    | Data Stores      | 22     | 0      | 0       | 0     | 22    | ✅     |
    | Plan             | 49     | 0      | 1       | 0     | 50    | ✅     |
    | Govern           | 26     | 0      | 5       | 0     | 31    | ✅     |
    | Create           | 28     | 0      | 1       | 0     | 29    | ✅     |
    | Verify           | 12     | 0      | 0       | 2     | 12    | ❗     |
    | Manage           | 12     | 0      | 3       | 1     | 15    | ❗     |
    | Package          | 0      | 0      | 1       | 0     | 1     | ➖     |
    | Framework sanity | 9      | 0      | 1       | 0     | 10    | ✅     |
    | Monitor          | 4      | 0      | 0       | 0     | 4     | ✅     |
    +------------------+--------+--------+---------+-------+-------+--------+
    | Total            | 162    | 0      | 12      | 3     | 174   | ❗     |
    +------------------+--------+--------+---------+-------+-------+--------+

    e2e-package-and-test: :x: test report for 51f84d13

    expand test summary
    +-----------------------------------------------------------------------+
    |                            suites summary                             |
    +------------------+--------+--------+---------+-------+-------+--------+
    |                  | passed | failed | skipped | flaky | total | result |
    +------------------+--------+--------+---------+-------+-------+--------+
    | Plan             | 312    | 0      | 0       | 117   | 312   | ❗     |
    | Manage           | 218    | 1      | 17      | 100   | 236   | ❌     |
    | Create           | 824    | 5      | 37      | 350   | 866   | ❌     |
    | Growth           | 0      | 0      | 10      | 0     | 10    | ➖     |
    | Verify           | 259    | 0      | 45      | 254   | 304   | ❗     |
    | Govern           | 235    | 0      | 0       | 234   | 235   | ❗     |
    | Release          | 30     | 0      | 0       | 25    | 30    | ❗     |
    | Package          | 144    | 0      | 41      | 144   | 185   | ❗     |
    | Data Stores      | 185    | 0      | 3       | 60    | 188   | ❗     |
    | Fulfillment      | 12     | 0      | 110     | 2     | 122   | ❗     |
    | Configure        | 1      | 0      | 15      | 0     | 16    | ✅     |
    | Secure           | 35     | 0      | 25      | 35    | 60    | ❗     |
    | Monitor          | 53     | 0      | 0       | 49    | 53    | ❗     |
    | Analytics        | 11     | 0      | 0       | 10    | 11    | ❗     |
    | ModelOps         | 0      | 0      | 5       | 0     | 5     | ➖     |
    | Systems          | 19     | 0      | 0       | 0     | 19    | ✅     |
    | GitLab Metrics   | 2      | 0      | 1       | 0     | 3     | ✅     |
    | Framework sanity | 0      | 0      | 7       | 0     | 7     | ➖     |
    +------------------+--------+--------+---------+-------+-------+--------+
    | Total            | 2340   | 6      | 316     | 1380  | 2662  | ❌     |
    +------------------+--------+--------+---------+-------+-------+--------+
  • Savas Vedova added 1 commit

    added 1 commit

    Compare with previous version

  • Savas Vedova marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed

    marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed

  • Savas Vedova
  • Savas Vedova assigned to @subashis and unassigned @svedova

    assigned to @subashis and unassigned @svedova

  • mentioned in epic &8353 (closed)

  • Neil McCorrison assigned to @mlapierre and @willmeek and unassigned @subashis

    assigned to @mlapierre and @willmeek and unassigned @subashis

  • Neil McCorrison changed title from Fix failing QA specs to Update failing QA specs

    changed title from Fix failing QA specs to Update failing QA specs

  • Neil McCorrison changed title from Update failing QA specs to Update failing QA specs on MR security widget

    changed title from Update failing QA specs to Update failing QA specs on MR security widget

  • Neil McCorrison changed the description

    changed the description

  • mentioned in epic &5629 (closed)

  • Subashis Chakraborty requested review from @dpisek

    requested review from @dpisek

  • David Pisek approved this merge request

    approved this merge request

  • :wave: @dpisek, thanks for approving this merge request.

    This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.

    For more info, please refer to the following links:

  • Will Meek
  • Will Meek
  • Will Meek mentioned in merge request !115920 (merged)

    mentioned in merge request !115920 (merged)

  • added 1 commit

    Compare with previous version

  • Will Meek approved this merge request

    approved this merge request

  • requested review from @mlapierre

  • David Pisek resolved all threads

    resolved all threads

  • David Pisek enabled an automatic merge when the pipeline for b39d6195 succeeds

    enabled an automatic merge when the pipeline for b39d6195 succeeds

  • merged

  • David Pisek mentioned in commit 2735f542

    mentioned in commit 2735f542

  • added workflowstaging label and removed workflowcanary label

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading