Skip to content

Update failing QA specs on MR security widget

Savas Vedova requested to merge govern-fix-ee-specs into master

What does this MR do and why?

We made several changes to the MR Widget. It's currently behind the :refactor_security_extension feature flag. Turning on causes some of the E2E specs to fail. More ref here: #361797 (comment 1323278930)

One of the reasons of the failures was the missing qa selectors. This MR adds these selectors. Apart from that, we also changed the way data is loaded. In the previous version, the issue, merge_request and dismissal feedback was included in the API call. Now, we fetch this information on demand when the modal is opened. Since E2E specs do not consider the network request, they fail. Additionally, we covered this UX on the frontend by adding a loading indicator to the modal in Frontend: Add loading state to the finding modal (#396260 - closed)

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

How to set up and validate locally

  1. cd gitlab/qa
  2. bundle exec bin/qa Test::Instance::All http://gdk.test:3000 -- qa/specs/features/ee/browser_ui/10_govern/create_merge_request_with_secure_spec.rb:58
  3. bundle exec bin/qa Test::Instance::All http://gdk.test:3000 -- qa/specs/features/ee/browser_ui/10_govern/vulnerability_management_spec.rb

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Neil McCorrison

Merge request reports