Issues list: change status to use badge component
What does this MR do and why?
Changes the status on issues list to use the badge
component.
Related to Merge request list: Change status to use badge ... (!114745 - merged)
Screenshots or screen recordings
Before | After |
---|---|
![]() |
![]() |
![]() |
![]() |
How to set up and validate locally
- Group list: http://gdk.test:3000/groups/flightjs/-/issues/?sort=created_date&state=all&last_page_size=20&page_before=eyJjcmVhdGVkX2F0IjoiMjAyMi0wMi0yNyAxODozOTowMC42MzA1OTUwMDAgKzAwMDAiLCJpZCI6IjI4MSJ9
- Project list: http://gdk.test:3000/flightjs/Flight/-/issues/?sort=created_date&state=all&first_page_size=20&page_after=eyJjcmVhdGVkX2F0IjoiMjAyMi0wMy0wOSAxODozOTo0OS4xMDA4NTIwMDAgKzAwMDAiLCJpZCI6IjQ2MCJ9
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
changed milestone to %15.11
added UX UX Paper Cuts frontend groupux paper cuts maintenanceusability sectiondev severity4 typemaintenance + 1 deleted label
assigned to @seggenberger
Please wait for Reviewer Roulette to suggest a designer for UX review, and then assign them as Reviewer. This helps evenly distribute reviews across UX.
This message was generated automatically. You're welcome to improve it.
mentioned in issue #398228 (closed)
- A deleted user
added backend label
2 Warnings You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the maintenancepipelines, maintenancerefactor, maintenanceworkflow, documentation, QA labels.This merge request changed undocumented Vue components in
vue_shared/
. Please consider creating Stories for these components:app/assets/javascripts/vue_shared/issuable/list/components/issuable_item.vue
app/assets/javascripts/vue_shared/issuable/list/components/issuable_list_root.vue
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Thomas Hutterer (
@thutterer
) (UTC+2, same timezone as@seggenberger
)Dylan Griffith (
@DylanGriffith
) (UTC+11, 9 hours ahead of@seggenberger
)frontend Janis Altherr (
@janis
) (UTC+2, same timezone as@seggenberger
)Andrew Fontaine (
@afontaine
) (UTC-4, 6 hours behind@seggenberger
)UX Becka Lippert (
@beckalippert
) (UTC-5, 7 hours behind@seggenberger
)Maintainer review is optional for UX To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangerrequested review from @psjakubowska, @leetickett-gitlab, and @annabeldunstone
- Resolved by Sascha Eggenberger
Hey
@annabeldunstone another refactoring
@psjakubowska can you do the frontend review?
@leetickett-gitlab can you do the backend review?
TY'll!
Edited by Sascha Eggenberger
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 189790f8 and 8330dff0
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.62 MB 3.62 MB - 0.0 % mainChunk 2.08 MB 2.08 MB - 0.0 %
Note: We do not have exact data for 189790f8. So we have used data from: 47231c54.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
Dangerrequested review from @mkozono and removed review request for @leetickett-gitlab
@leetickett-gitlab
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
Allure report
allure-report-publisher
generated test report!e2e-review-qa:
test report for 8330dff0expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Data Stores | 22 | 0 | 0 | 0 | 22 | ✅ | | Verify | 12 | 0 | 0 | 2 | 12 | ❗ | | Create | 28 | 0 | 1 | 0 | 29 | ✅ | | Plan | 49 | 0 | 1 | 0 | 50 | ✅ | | Govern | 26 | 0 | 5 | 0 | 31 | ✅ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | | Manage | 11 | 0 | 3 | 0 | 14 | ✅ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Framework sanity | 9 | 0 | 1 | 0 | 10 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 161 | 0 | 12 | 2 | 173 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+
added 1 commit
- 736db2aa - Issues list: change status to use badge component
- Resolved by Sascha Eggenberger
added 1 commit
- 34ba9966 - Issues list: change status to use badge component
requested review from @afontaine and removed review request for @psjakubowska
removed review request for @afontaine
removed review request for @annabeldunstone
removed review request for @mkozono
- Resolved by Andrew Fontaine
@afontaine The
gitlab.pot
was regenerated and added. Can you set MWPS?
requested review from @afontaine
added 840 commits
-
34ba9966...24cf6e6e - 839 commits from branch
master
- f21136c9 - Issues list: change status to use badge component
-
34ba9966...24cf6e6e - 839 commits from branch
added 1 commit
- 8330dff0 - Issues list: change status to use badge component
That seemed to do it
thanks @seggenbergermentioned in commit 079ac837
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!2061 (merged)
mentioned in merge request gitlab-com/www-gitlab-com!131747 (merged)