Skip to content

Restore breadcrumb border for all pages

Scott de Jonge requested to merge breadcrumbs-restore-border into master

What does this MR do and why?

From: https://gitlab.slack.com/archives/C010NAWPRV4/p1679266947944489

Restore breadcrumb border removed in !113390 (merged) to enable border and spacing to be consistent when super sidebar collapse update is implemented.

Changes

  • Restore border styles on .breadcrumb-container
  • Remove @no_breacrumb_border variable usage from templates
  • Remove @no_breacrumb_border removing border styles
  • Update top spacing in templates to $gl-spacing-scale-4 (12px)
  • Update .page-title spacing to $gl-spacing-scale-4 (12px) when inside .page-title-holder
  • Update "New issue" page to use .page-title-holder

Screenshots or screen recordings

Page Before After
Epic 127.0.0.1_3000_groups_flightjs_-_epics_5 127.0.0.1_3000_groups_flightjs_-_epics_5
Issue 127.0.0.1_3000_flightjs_Flight_-_issues_33 127.0.0.1_3000_flightjs_Flight_-_issues_33
New issue 127.0.0.1_3000_flightjs_Flight_-_issues_new 127.0.0.1_3000_flightjs_Flight_-_issues_new
Projects 127.0.0.1_3000_dashboard_projects 127.0.0.1_3000_dashboard_projects
Project 127.0.0.1_3000_flightjs_Flight 127.0.0.1_3000_flightjs_Flight
Milestone 127.0.0.1_3000_flightjs_Flight_-_milestones_6 127.0.0.1_3000_flightjs_Flight_-_milestones_6
Issues 127.0.0.1_3000_dashboard_issues_sort_priority_state_opened_assignee_username___root 127.0.0.1_3000_dashboard_issues_sort_priority_state_opened_assignee_username___root
Merge requests 127.0.0.1_3000_dashboard_merge_requests_assignee_username_root 127.0.0.1_3000_dashboard_merge_requests_assignee_username_root
To-do list 127.0.0.1_3000_dashboard_todos 127.0.0.1_3000_dashboard_todos
Incident 127.0.0.1_3000_flightjs_Flight_-_issues_incident_34 127.0.0.1_3000_flightjs_Flight_-_issues_incident_34
Files 127.0.0.1_3000_flightjs_Flight_-_tree_master 127.0.0.1_3000_flightjs_Flight_-_tree_master

How to set up and validate locally

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Scott de Jonge

Merge request reports