Skip to content

Fix bug with branch selector showing on group level instead of input

Alexander Turinske requested to merge fix-license-scanning-on-group-level into master

What does this MR do and why?

Describe in detail what your merge request does and why.

Update group-level branch selector to be a dropdown and input

  • group-level scan result policy branch selector was an empty dropdown instead of an input
  • show input if users want to select a specific branch
  • remove redundant (and wrong) tests

Changelog: fixed

EE: true

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Scenario Video
Group level group_selector
Project level project_selector

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. Upload a GitLab Ultimate license
  2. Navigate to a group => Security & Compliance => Policie => New policy => Scan Result Policy => Select either scan
  3. Verify branch selector is an input
  4. Navigate to a project => Security & Compliance => Policie => New policy => Scan Result Policy => Select either scan
  5. Verify branch selector is an select

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Alexander Turinske

Merge request reports