Skip to content

Step 3 - Cleanup BigInt conversion for ci_build_needs

What does this MR do and why?

See overall instructions for converting primary key to bigint at https://docs.gitlab.com/ee/development/database/avoiding_downtime_in_migrations.html#migrating-integer-primary-keys-to-bigint . This is the Remove the trigger and old integer columns (release N + 2) step and the previous step was completed in !112444 (diffs) .

Cleanup BigInt conversion for ci_build_needs

  • remove column id_convert_to_bigint
  • remove trigger_3207b8d0d6f3 trigger and function

up

main: == 20230321163547 CleanupConversionBigIntCiBuildNeeds: migrating ==============
main: -- transaction_open?()
main:    -> 0.0000s
main: -- remove_column(:ci_build_needs, "id_convert_to_bigint")
main:    -> 0.0014s
main: == 20230321163547 CleanupConversionBigIntCiBuildNeeds: migrated (0.0202s) =====

ci: == 20230321163547 CleanupConversionBigIntCiBuildNeeds: migrating ==============
ci: -- transaction_open?()
ci:    -> 0.0000s
ci: -- remove_column(:ci_build_needs, "id_convert_to_bigint")
ci:    -> 0.0011s
ci: == 20230321163547 CleanupConversionBigIntCiBuildNeeds: migrated (0.0125s) =====

down

 bin/rake db:migrate:down:main VERSION=20230321163547
main: == 20230321163547 CleanupConversionBigIntCiBuildNeeds: reverting ==============
main: -- table_exists?(:ci_build_needs)
main:    -> 0.0304s
main: -- column_exists?(:ci_build_needs, :id)
main:    -> 0.0024s
main: -- column_exists?(:ci_build_needs, :id)
main:    -> 0.0009s
main: -- transaction_open?()
main:    -> 0.0000s
main: -- columns(:ci_build_needs)
main:    -> 0.0010s
main: -- add_column(:ci_build_needs, "id_convert_to_bigint", :int, {:default=>0, :null=>false})
main:    -> 0.0026s
main: == 20230321163547 CleanupConversionBigIntCiBuildNeeds: reverted (0.0542s) =====

 bin/rake db:migrate:down:ci VERSION=20230321163547
ci: == 20230321163547 CleanupConversionBigIntCiBuildNeeds: reverting ==============
ci: -- table_exists?(:ci_build_needs)
ci:    -> 0.0538s
ci: -- column_exists?(:ci_build_needs, :id)
ci:    -> 0.0024s
ci: -- column_exists?(:ci_build_needs, :id)
ci:    -> 0.0010s
ci: -- transaction_open?()
ci:    -> 0.0000s
ci: -- columns(:ci_build_needs)
ci:    -> 0.0012s
ci: -- add_column(:ci_build_needs, "id_convert_to_bigint", :int, {:default=>0, :null=>false})
ci:    -> 0.0037s
ci: == 20230321163547 CleanupConversionBigIntCiBuildNeeds: reverted (0.0901s) =====

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

#389343 (closed)

Edited by Dylan Griffith

Merge request reports