Groups - README
What does this MR do and why?
Built off the base MR from @peterhegman: !110943 (closed)
Closes #392015 (closed)
This change hooks up the ability to display a README on the Group Information page via a specially named project gitlab-profile
.
This is behind the feature flag (:show_group_readme)
Screenshots or screen recordings
w/ README Project | w/o README Project | |
---|---|---|
Group | ![]() |
![]() |
Subgroup | ![]() |
![]() |
How to set up and validate locally
- Enable the Feature Flag
Feature.enable(:show_group_readme)
- I've had issues lately with FF caching, I'd suggest maybe restarting GDK
- Go to a Group or Subgroup
- Create a project named exactly
gitlab-profile
- Add a
README.md
to the project - Go back to the Group Information page
- Ensure
README.md
is present under the list of Projects/Subgroups
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #392015 (closed)
Merge request reports
Activity
changed milestone to %15.11
assigned to @zcuddy
- Resolved by Zack Cuddy
Hey @peterhegman! Would you have capacity to give this just a quick look over before I send it down the review paths?
requested review from @peterhegman
- A deleted user
added backend label
1 Warning ⚠ featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.
For more information, see:
- The Handbook page on merge request types.
- The definition of done documentation.
1 Message 📖 CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the
Changelog
trailer to the commit message you want to add to the changelog.If you want to create a changelog entry for GitLab EE, also add the
EE: true
trailer to your commit message.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Alex Buijs (
@alexbuijs
) (UTC+2, 7 hours ahead of@zcuddy
)Roy Zwambag (
@rzwambag
) (UTC+2, 7 hours ahead of@zcuddy
)frontend Fernando Cardenas (
@fernando-c
) (UTC-5, same timezone as@zcuddy
)Jose Ivan Vargas (
@jivanvl
) (UTC-6, 1 hour behind@zcuddy
)test for spec/features/*
Alex Buijs (
@alexbuijs
) (UTC+2, 7 hours ahead of@zcuddy
)Maintainer review is optional for test for spec/features/*
UX Michael Fangman (
@mfangman
) (UTC-5, same timezone as@zcuddy
)Maintainer review is optional for UX To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
🔁 danger-review
job that generated this comment.Generated by
🚫 DangerBundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 3322a79d and 1700c20c
✨ Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.62 MB 3.62 MB - 0.0 % mainChunk 2.08 MB 2.08 MB - 0.0 %
Note: We do not have exact data for 3322a79d. So we have used data from: 58dcce6a.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun thebundle-size-review
job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.Please look at the full report for more details
Read more about how this report works.
Generated by
🚫 DangerAllure report
allure-report-publisher
generated test report!e2e-review-qa:
✅ test report for 1700c20cexpand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Verify | 10 | 0 | 0 | 0 | 10 | ✅ | | Plan | 49 | 0 | 1 | 0 | 50 | ✅ | | Data Stores | 22 | 0 | 0 | 0 | 22 | ✅ | | Govern | 26 | 0 | 5 | 0 | 31 | ✅ | | Manage | 8 | 0 | 3 | 0 | 11 | ✅ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | | Create | 28 | 0 | 1 | 0 | 29 | ✅ | | Framework sanity | 9 | 0 | 1 | 0 | 10 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 156 | 0 | 12 | 0 | 168 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+
added UX label
Please wait for Reviewer Roulette to suggest a designer for UX review, and then assign them as Reviewer. This helps evenly distribute reviews across UX.
This message was generated automatically. You're welcome to improve it.
- Resolved by Fernando Cardenas
Hey @fernando-c! Do you have capacity for a frontend review on this new feature behind a feature flag?
Please let me know if you have any questions
🙇
- Resolved by Zack Cuddy
Hey @tle_gitlab! Do you have capacity for a backend and test review on this new feature behind a feature flag?
Please let me know if you have any questions
🙇 Edited by Zack Cuddy
- Resolved by Zack Cuddy
Hey @lvanc! Do you have capacity for a UX review on this new feature behind a feature flag?
Please let me know if you have any questions
🙇
requested review from @fernando-c, @tle_gitlab, and @lvanc and removed review request for @peterhegman
mentioned in merge request !115604 (merged)
👋 @lvanc
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
removed review request for @lvanc
- Resolved by Zack Cuddy
- Resolved by Zack Cuddy
- Resolved by Zack Cuddy
- Resolved by Tan Le
removed review request for @tle_gitlab
mentioned in issue #392016 (closed)
added 599 commits
-
3aebbd74...e235dbd8 - 597 commits from branch
master
- 06566108 - Groups - README
- 538474b3 - Changes based on @tle_gitlab feedback
-
3aebbd74...e235dbd8 - 597 commits from branch
requested review from @tle_gitlab
- Resolved by Tan Le
- Resolved by Fernando Cardenas
- Resolved by Fernando Cardenas
- Resolved by Fernando Cardenas
- Resolved by Zack Cuddy
requested review from @zcuddy
- Resolved by Tan Le
- Resolved by Zack Cuddy
- Resolved by Zack Cuddy
removed review request for @tle_gitlab
added 503 commits
-
4a7d0c58...a30381b5 - 499 commits from branch
master
- a25ea5b4 - Groups - README
- 44a1b62b - Changes based on @tle_gitlab feedback
- 8920a475 - Addl changes based on @tle_gitlab feedback
- 5bf249b3 - Changes based on @fernando-c feedback
Toggle commit list-
4a7d0c58...a30381b5 - 499 commits from branch
mentioned in merge request !110943 (closed)
requested review from @tle_gitlab and removed review request for @zcuddy
- Resolved by Zack Cuddy
Thanks for
🐻 -ing with me, @zcuddy🙏🏼 . The MR is shaping up quite nicely. I have left some suggestions. Please let me know what you think.requested review from @zcuddy
removed review request for @tle_gitlab
added 554 commits
-
5bf249b3...9b0f6913 - 549 commits from branch
master
- 9883bb30 - Groups - README
- 37fe7e95 - Changes based on @tle_gitlab feedback
- 3764dc45 - Addl changes based on @tle_gitlab feedback
- 0d70101d - Changes based on @fernando-c feedback
- 296055a6 - Changes based on reviewer feedback
Toggle commit list-
5bf249b3...9b0f6913 - 549 commits from branch