Skip to content

Move member roles factories to EE

Peter Leitzen requested to merge pl-facories-member-role into master

What does this MR do and why?

This MR moves member roles factories to ee/spec/factories/member_roles.rb because it's defined in Enterprise Edition. Previously, (in https://gitlab.com/gitlab-org/gitlab/-/jobs/3965819533) it failed when run with FOSS_ONLY=1. See !110361 (comment 1320714895).

It also skip specs which are related to Geo if the Geo database is not set up.

Closes #397700 (closed).

Follow-up of !110361 (merged).

How to set up and validate locally

# Verify without Geo
bin/rspec ee/spec/models/factories_spec.rb -e geo

# All Geo specs are skipped

# Verify with Geo
bin/rspec ee/spec/models/factories_spec.rb

# All Geo specs are now run
# See CI trace output from <LINK>

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Peter Leitzen

Merge request reports