Don't autofocus comment field with content editor
What does this MR do and why?
Autofocus of the textarea on load means shortcut keys don't work (up/down arrows of gitlab shortcuts). Maybe there are some places we want this (expanding discussions?), but not for initial page load.
How to set up and validate locally
- Enable the flag
Feature.enable(:content_editor_on_issues)
- Visit any issue or MR
- press down arrow
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
changed milestone to %15.11
assigned to @psimyn
added sectiondev label
added typebug label
@himkp can you please review?
Not sure if this came up already but just noticed it today
Edited by Simon Knoxassigned to @himkp
2 Warnings ⚠ You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the maintenancepipelines, maintenancerefactor, maintenanceworkflow, documentation, QA labels.⚠ Please add a merge request subtype to this merge request. 1 Message 📖 CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the
Changelog
trailer to the commit message you want to add to the changelog.If you want to create a changelog entry for GitLab EE, also add the
EE: true
trailer to your commit message.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend Ammar Alakkad (
@aalakkad
) (UTC+3, 8 hours behind@psimyn
)Alexander Turinske (
@aturinske
) (UTC+13, 2 hours ahead of@psimyn
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
🔁 danger-review
job that generated this comment.Generated by
🚫 Dangerrequested review from @himkp
unassigned @himkp
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits ddf81ba9 and 91216ed3
✨ Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.56 MB 3.56 MB - -0.0 % mainChunk 2.05 MB 2.05 MB - 0.0 %
Note: We do not have exact data for ddf81ba9. So we have used data from: a95af5d3.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun thebundle-size-review
job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.Please look at the full report for more details
Read more about how this report works.
Generated by
🚫 DangerAllure report
allure-report-publisher
generated test report!e2e-review-qa:
❗ test report for 91216ed3expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Create | 28 | 0 | 1 | 0 | 29 | ✅ | | Govern | 26 | 0 | 5 | 5 | 31 | ❗ | | Manage | 34 | 0 | 3 | 1 | 37 | ❗ | | Plan | 49 | 0 | 1 | 0 | 50 | ✅ | | Verify | 12 | 0 | 0 | 3 | 12 | ❗ | | Framework sanity | 9 | 0 | 1 | 0 | 10 | ✅ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 162 | 0 | 12 | 9 | 174 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+
👋 @himkp
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
mentioned in commit b789c566
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
mentioned in issue #397705 (closed)
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added Pick into 15.10 label
added workflowpost-deploy-db-production label and removed workflowproduction label
Starting with 15.10, there is a new engineering process for patch releases so the
Pick into 15.10
label will not have any effect. For this merge request to be included in the next patch release for 15.10, a backport has to be created and merged into the15-10-stable-ee
branch. Please refer to the runbook for guidelines and take a look at the announcement issue for more details.Feedback and questions welcome, you can drop them on the announcement issue or on the #releases slack channel.
thanks @mayra-cabrera, I hadn't known about this. I will create backport MR
mentioned in issue gitlab-com/gl-infra/delivery#2890 (closed)
Removing the Pick into 15.10 because this was backported on !115465 (merged)
removed Pick into 15.10 label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label