Skip to content

Update `:focus` to `:focus-visible` for super sidebar focus styles

Scott de Jonge requested to merge super-sidebar-focus-visible into master

What does this MR do and why?

From: https://gitlab.slack.com/archives/C04G34U119T/p1679229292351279?thread_ts=1678374282.211139&cid=C04G34U119T

Update :focus to :focus-visible for super sidebar focus styles

Screenshots or screen recordings

CleanShot_2023-03-20_at_10.39.47

How to set up and validate locally

  • Enable the feature flag in rails console with rails c 
Feature.enable(:super_sidebar_nav)
  • Enable the "New navigation" setting toggle from the user dropdown

CleanShot_2023-01-24_at_17.50.44_2x

  • Collapse/expand the super sidebar with keyboard tdb/enter, a focus-ring should be shown when sidebar is expanded
  • Use a mouse to toggle sidebar, no focus-ring should be visible

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Scott de Jonge

Merge request reports