Skip to content
Snippets Groups Projects

Adjust tests to api admin mode (12)

Merged Andreas Deicha requested to merge gitlab-community/gitlab:api_admin_mode_test_12 into master
All threads resolved!

What does this MR do and why?

Adjusts test to api admin mode

issue

implementation plan

tests to adjust

how to improve

I left some comments in code where I need help. Look for # why does this work without admin_mode?

🛠 with at Siemens

How to set up and validate locally

  • bin/rspec ee/spec/requests/api/vulnerabilities_spec.rb
  • bin/rspec ee/spec/requests/api/vulnerability_exports_spec.rb
  • bin/rspec ee/spec/requests/api/vulnerability_findings_spec.rb
  • bin/rspec ee/spec/requests/api/vulnerability_issue_links_spec.rb

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Andreas Deicha

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Brian Williams removed review request for @bwill

    removed review request for @bwill

  • Andreas Deicha added 1 commit

    added 1 commit

    • 7b90062b - Adjust tests to api admin mode

    Compare with previous version

  • Brian Williams resolved all threads

    resolved all threads

  • Brian Williams approved this merge request

    approved this merge request

  • Brian Williams enabled an automatic merge when the pipeline for f3654e3c succeeds

    enabled an automatic merge when the pipeline for f3654e3c succeeds

  • merged

  • Brian Williams mentioned in commit d72bacd6

    mentioned in commit d72bacd6

  • @TrueKalix, how was your code review experience with this merge request? Please tell us how we can continue to iterate and improve:

    1. React with a 👍 or a 👎 on this comment to describe your experience.
    2. Create a new comment starting with @gitlab-bot feedback below, and leave any additional feedback you have for us in the comment.

    Interested in learning more tips and tricks to solve your next challenge faster? Subscribe to the GitLab Community Newsletter for contributor-focused content and opportunities to level up.

    Thanks for your help!

    This message was generated automatically. You're welcome to improve it.

  • added workflowstaging label and removed workflowcanary label

  • Please register or sign in to reply
    Loading