Adjust tests to api admin mode (12)
What does this MR do and why?
Adjusts test to api admin mode
I left some comments in code where I need help. Look for # why does this work without admin_mode?
How to set up and validate locally
bin/rspec ee/spec/requests/api/vulnerabilities_spec.rb
bin/rspec ee/spec/requests/api/vulnerability_exports_spec.rb
bin/rspec ee/spec/requests/api/vulnerability_findings_spec.rb
bin/rspec ee/spec/requests/api/vulnerability_issue_links_spec.rb
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
added Leading Organization label
Hey @TrueKalix!
👋 Thank you for your contribution to GitLab. Please refer to the contribution flow documentation for a quick overview of the process, and the merge request (MR) guidelines for the detailed process.
When you're ready for a first review, post
@gitlab-bot ready
. If you know a relevant reviewer(s) (for example, someone that was involved in a related issue), you can also assign them directly with@gitlab-bot ready @user1 @user2
.At any time, if you need help, feel free to post
@gitlab-bot help
or initiate a mentor session on Discord. Read more on how to get help.You can comment
@gitlab-bot label <label1> <label2>
to add labels to your MR. Please see the list of allowed labels in thelabel
command documentation.This message was generated automatically. You're welcome to improve it.
added Community contribution workflowin dev labels
assigned to @TrueKalix
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Tiger Watson (
@tigerwnz
) (UTC+11)Alex Pooley (
@alexpooley
) (UTC+8)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
🔁 danger-review
job that generated this comment.Generated by
🚫 Danger@gitlab-bot ready
added workflowready for review label and removed workflowin dev label
@terrichu
, this Community contribution is ready for review.- Do you have capacity and domain expertise to review this? We are mindful of your time, so if you are not able to take this on, please re-assign to one or more other reviewers.
- Add the workflowin dev label if the merge request needs action from the author. This message was generated automatically. You're welcome to improve it.
requested review from @terrichu
added groupthreat insights maintenancerefactor typemaintenance labels
added devopsgovern sectionsec labels
- Resolved by Brian Williams
@TrueKalix thanks for the contribution
😄 Everything LGTM, @bwill would you mind taking maintainer review for this MR (I believe your team is DRI for one or more of the APIs in this MR)🙇
- Resolved by Brian Williams
👋 @terrichu
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, please start a new pipeline before merging.
For more info, please refer to the following links:
added pipeline:mr-approved label
- A deleted user
added backend label
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Tiger Watson (
@tigerwnz
) (UTC+11)Alex Pooley (
@alexpooley
) (UTC+8)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
🔁 danger-review
job that generated this comment.Generated by
🚫 Dangerchanged milestone to %15.11
mentioned in issue gitlab-org/quality/triage-reports#11709 (closed)
- Resolved by Brian Williams
added workflowin dev label and removed workflowready for review label
removed review request for @bwill
enabled an automatic merge when the pipeline for f3654e3c succeeds
mentioned in commit d72bacd6
@TrueKalix, how was your code review experience with this merge request? Please tell us how we can continue to iterate and improve:
- React with a
👍 or a👎 on this comment to describe your experience. - Create a new comment starting with
@gitlab-bot feedback
below, and leave any additional feedback you have for us in the comment.
Interested in learning more tips and tricks to solve your next challenge faster? Subscribe to the GitLab Community Newsletter for contributor-focused content and opportunities to level up.
Thanks for your help!
❤ This message was generated automatically. You're welcome to improve it.
- React with a
added workflowstaging-canary label and removed workflowin dev label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-production label and removed workflowproduction label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label