Skip to content

Create variables for application header, footer, and viewport heights

Scott de Jonge requested to merge top-bottom-position-mixins into master

What does this MR do and why?

  • $calc-application-header-height: system header, performance bar, and header when present
  • $calc-application-footer-height system footer when present
  • $calc-application-viewport-height full height minus system header, performance bar, header, and/or system footer when present
  • Update existing top/bottom/height usage with variables
  • Remove explicit .with-performance-bar, .with-system-header, and .with-system-footer styles
  • Move .fixed-top style override to utilties.scss
  • Remove content-wrapper-margin styles and class usage (as per #332705 (closed))
    • Instead use layout-page with padding-top/padding-bottom for fixed elements on any given page

Screenshots or screen recordings

Before After
CleanShot_2023-03-21_at_11.50.22 CleanShot_2023-03-21_at_12.11.43
127.0.0.1_3000_flightjs_Flight_-merge_requests_4_diffs__4 127.0.0.1_3000_flightjs_Flight_-merge_requests_4_diffs__5
top-position-before top-position-after

How to set up and validate locally

Add system header/footer messages in admin settings and review views:

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Scott de Jonge

Merge request reports