Delete frontend code for self-monitoring
What does this MR do and why?
Deletes and removes code related to Self-monitoring removals.
Address frontend from #394992 (closed).
Screenshots or screen recordings
NA
How to set up and validate locally
- Check Admin > Settings > Metrics and profiling
- You should not see the
Self-monitoring
option in the list.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #394992 (closed)
Merge request reports
Activity
changed milestone to %16.0
added devopsmonitor frontend grouprespond sectionops labels
assigned to @rkadam3
- A deleted user
added backend label
3 Warnings This merge request is quite big (993 lines changed), please consider splitting it into multiple merge requests. You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the maintenancepipelines, maintenancerefactor, maintenanceworkflow, documentation, QA labels.Please add a merge request subtype to this merge request. 1 Message CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the
Changelog
trailer to the commit message you want to add to the changelog.If you want to create a changelog entry for GitLab EE, also add the
EE: true
trailer to your commit message.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Eugenia Grieff (
@egrieff
) (UTC+2, 3.5 hours behind@rkadam3
)Peter Leitzen (
@splattael
) (UTC+2, 3.5 hours behind@rkadam3
)frontend Fernando Cardenas (
@fernando-c
) (UTC-4, 9.5 hours behind@rkadam3
)Miguel Rincon (
@mrincon
) (UTC+2, 3.5 hours behind@rkadam3
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger- Resolved by Rajendra Kadam
@rkadam3 - please see the following guidance and update this merge request.1 Error Please add typebug typefeature, or typemaintenance label to this merge request.
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits c909b1bd and 12976591
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.64 MB 3.64 MB - -0.0 % mainChunk 2.08 MB 2.08 MB - 0.0 %
Note: We do not have exact data for c909b1bd. So we have used data from: 2b344b95.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun thebundle-size-review
job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.Please look at the full report for more details
Read more about how this report works.
Generated by
Dangermentioned in merge request !115000 (merged)
mentioned in issue gitlab-org/monitor/respond#217 (closed)
mentioned in issue gitlab-org/monitor/respond#225 (closed)
mentioned in issue gitlab-org/monitor/respond#226 (closed)
mentioned in issue gitlab-org/monitor/respond#230 (closed)
added 5924 commits
-
1f3a1ba0...7c212d27 - 5922 commits from branch
master
- 0278fea6 - Delete frontend code for self-monitoring
- 0c36ebc9 - Remove occurrences in js files
-
1f3a1ba0...7c212d27 - 5922 commits from branch
added typemaintenance label
- Resolved by Gary Holtz
Allure report
allure-report-publisher
generated test report!e2e-review-qa:
test report for 12976591expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Plan | 49 | 0 | 1 | 0 | 50 | ✅ | | Create | 28 | 0 | 1 | 0 | 29 | ✅ | | Data Stores | 22 | 0 | 0 | 0 | 22 | ✅ | | Verify | 10 | 0 | 0 | 0 | 10 | ✅ | | Manage | 8 | 0 | 3 | 0 | 11 | ✅ | | Govern | 24 | 0 | 0 | 0 | 24 | ✅ | | Framework sanity | 9 | 0 | 1 | 0 | 10 | ✅ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 154 | 0 | 7 | 0 | 161 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+
@ramistry
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
removed review request for @mrincon
added 46 commits
-
0c36ebc9...192812e1 - 44 commits from branch
master
- 52a2f4d0 - Delete frontend code for self-monitoring
- db18b787 - Remove occurrences in js files
-
0c36ebc9...192812e1 - 44 commits from branch
requested review from @mrincon
removed review request for @mrincon
- Resolved by Rajendra Kadam
enabled an automatic merge when the pipeline for 33b6ceda succeeds
- Resolved by Miguel Rincon
@mrincon - I think I have fixed the pipeline failure and the issue was very obscure. I was surprised when I found it.
Do you mind taking a look and setting MWPS, please?
We have all other necesssary approvals.
Edited by Rajendra Kadam
requested review from @mrincon
mentioned in merge request !118590 (merged)
added 300 commits
-
731da6a9...c909b1bd - 299 commits from branch
master
- 12976591 - Delete frontend code for self-monitoring
-
731da6a9...c909b1bd - 299 commits from branch
enabled an automatic merge when the pipeline for ba277778 succeeds