Skip to content
Snippets Groups Projects

Project overview: remove container-limited class

Merged Sascha Eggenberger requested to merge project-overview-remove-container-limited into master
All threads resolved!

What does this MR do and why?

Removes

- @content_class = "limit-container-width" unless fluid_layout

from the Project overview page

Screenshots or screen recordings

Before After
overview_before overview_after
empty_before empty_after
security_before security_after
registry_before registry_after
ir_before ir_after
snipptet_before snippet_after

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. Check a project overview page (e.g. http://gdk.test:3000/flightjs/Flight)
  2. Create an empty project and check it's overview page
  3. Security configuration (e.g. http://gdk.test:3000/flightjs/Flight/-/security/configuration)
  4. Package registry (e.g. http://gdk.test:3000/flightjs/Flight/-/packages)
  5. Infrastructure registry (e.g. http://gdk.test:3000/flightjs/Flight/-/infrastructure_registry)
  6. Snippets (e.g. create a snippet on http://gdk.test:3000/flightjs/Flight/-/snippets)

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Sascha Eggenberger

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • added 1 commit

    • 0465985c - Project overview: remove container-limited class

    Compare with previous version

  • Simon Knox approved this merge request

    approved this merge request

  • Simon Knox resolved all threads

    resolved all threads

  • Simon Knox enabled an automatic merge when the pipeline for 464f3e24 succeeds

    enabled an automatic merge when the pipeline for 464f3e24 succeeds

  • Elwyn Benson removed review request for @elwyn-gitlab

    removed review request for @elwyn-gitlab

    • Resolved by Simon Knox

      @seggenberger failure is legit

      RSpec::Retry: 2nd try ./ee/spec/features/projects/quality/test_case_create_spec.rb:63
      
        1) Test cases test case create form creates a test case on saving form
           Got 1 failure and 1 other error:
           1.1) Failure/Error: expect(page).to have_selector('.content-wrapper .project-test-cases')
                  expected to find css ".content-wrapper .project-test-cases" but there were no matches
  • Simon Knox
  • Simon Knox unapproved this merge request

    unapproved this merge request

  • 🤖 GitLab Bot 🤖 changed milestone to %15.11

    changed milestone to %15.11

  • Sascha Eggenberger aborted the automatic merge because source branch was updated

    aborted the automatic merge because source branch was updated

  • Sascha Eggenberger added 696 commits

    added 696 commits

    Compare with previous version

  • Sascha Eggenberger added 15 commits

    added 15 commits

    Compare with previous version

  • Simon Knox resolved all threads

    resolved all threads

  • Simon Knox approved this merge request

    approved this merge request

  • Simon Knox enabled an automatic merge when the pipeline for da94ca51 succeeds

    enabled an automatic merge when the pipeline for da94ca51 succeeds

  • merged

  • Simon Knox mentioned in commit 76d5c9af

    mentioned in commit 76d5c9af

  • added workflowstaging label and removed workflowcanary label

  • Please register or sign in to reply
    Loading