Project overview: remove container-limited class
What does this MR do and why?
Removes
- @content_class = "limit-container-width" unless fluid_layout
from the Project overview page
Screenshots or screen recordings
Before | After |
---|---|
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
- Check a project overview page (e.g. http://gdk.test:3000/flightjs/Flight)
- Create an empty project and check it's overview page
- Security configuration (e.g. http://gdk.test:3000/flightjs/Flight/-/security/configuration)
- Package registry (e.g. http://gdk.test:3000/flightjs/Flight/-/packages)
- Infrastructure registry (e.g. http://gdk.test:3000/flightjs/Flight/-/infrastructure_registry)
- Snippets (e.g. create a snippet on http://gdk.test:3000/flightjs/Flight/-/snippets)
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
changed milestone to %15.10
added UX UX Paper Cuts frontend groupux paper cuts maintenanceusability sectiondev severity4 typemaintenance + 1 deleted label
assigned to @seggenberger
Please wait for Reviewer Roulette to suggest a designer for UX review, and then assign them as Reviewer. This helps evenly distribute reviews across UX.
This message was generated automatically. You're welcome to improve it.
Related to Remove «limit-container-width» (#391236)
- A deleted user
added backend label
2 Warnings This MR changes code in ee/
, but its Changelog commit is missing theEE: true
trailer. Consider adding it to your Changelog commits.You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the maintenancepipelines, maintenancerefactor, maintenanceworkflow, documentation, QA labels.Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Smriti Garg (
@sgarg_gitlab
) (UTC+5.5, 4.5 hours ahead of@seggenberger
)Sincheol (David) Kim (
@dskim_gitlab
) (UTC+10.5, 9.5 hours ahead of@seggenberger
)frontend Artur Fedorov (
@arfedoro
) (UTC+1, same timezone as@seggenberger
)Paul Slaughter (
@pslaughter
) (UTC-5, 6 hours behind@seggenberger
)UX Becka Lippert (
@beckalippert
) (UTC-5, 6 hours behind@seggenberger
)Maintainer review is optional for UX To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger- Resolved by Simon Knox
requested review from @lvanc and @elwyn-gitlab
@elwyn-gitlab
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
mentioned in issue gitlab-com/www-gitlab-com#31164 (closed)
@seggenberger Nice clean up work. Looks good to me!
removed review request for @lvanc
requested review from @psimyn
- Resolved by Sascha Eggenberger
- Resolved by Simon Knox
@seggenberger looks good - one small cleanup suggestion.
Is there an issue about this?
added 1 commit
- 0465985c - Project overview: remove container-limited class
enabled an automatic merge when the pipeline for 464f3e24 succeeds
removed review request for @elwyn-gitlab
- Resolved by Simon Knox
@seggenberger failure is legit
RSpec::Retry: 2nd try ./ee/spec/features/projects/quality/test_case_create_spec.rb:63 1) Test cases test case create form creates a test case on saving form Got 1 failure and 1 other error: 1.1) Failure/Error: expect(page).to have_selector('.content-wrapper .project-test-cases') expected to find css ".content-wrapper .project-test-cases" but there were no matches
- Resolved by Sascha Eggenberger
changed milestone to %15.11
added missed:15.10 label
added 696 commits
-
0465985c...433a1534 - 695 commits from branch
master
- 810630b8 - Project overview: remove container-limited class
-
0465985c...433a1534 - 695 commits from branch
added 15 commits
-
810630b8...ff9e5aea - 14 commits from branch
master
- 74ee4ffd - Project overview: remove container-limited class
-
810630b8...ff9e5aea - 14 commits from branch
enabled an automatic merge when the pipeline for da94ca51 succeeds
mentioned in commit 76d5c9af
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-production label and removed workflowproduction label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!2061 (merged)