Skip to content

Update stable checks to consider no downstream pipeline is generated

Mayra Cabrera requested to merge fixes-danger-error-with-no-downstream-pipeline into master

What does this MR do and why?

Update stable checks to consider no downstream pipeline is generated

The package-and-test bridge can be canceled which interrupts the generation of the downstream pipeline. This commit updates Danger stable branch checks to account for these scenarios. This will avoid Danger code failures when no downstream pipeline can be found (e.g. https://gitlab.com/gitlab-org/gitlab/-/jobs/3943016314)

/builds/gitlab-org/gitlab/tooling/danger/stable_branch.rb:105:in `package_and_test_bridge_and_pipeline_status': \e[31m (Danger::DSLError)
[!] Invalid `Dangerfile` file: \e[31m
[!] Invalid `Dangerfile` file: undefined method `fetch' for nil:NilClass. Updating the Danger gem might fix the issue. Your Danger version: 8.6.1, latest Danger version: 9.2.0
\e[0m
 #  from /builds/gitlab-org/gitlab/danger/stable_branch_patch/Dangerfile:14
 #  -------------------------------------------
 #  
 >  stable_branch.check!
 #  -------------------------------------------
. Updating the Danger gem might fix the issue. Your Danger version: 8.6.1, latest Danger version: 9.2.0
\e[0m
 #  from /builds/gitlab-org/gitlab/danger/stable_branch_patch/Dangerfile:14
 #  -------------------------------------------
 #    gitlab_dangerfiles.import_plugins
 >    gitlab_dangerfiles.config.ci_only_rules = ProjectHelper::CI_ONLY_RULES
 #    gitlab_dangerfiles.config.files_to_category = ProjectHelper::CATEGORIES
 #  -------------------------------------------
	from /builds/gitlab-org/gitlab/tooling/danger/stable_branch.rb:72:in `check!'
	from /builds/gitlab-org/gitlab/danger/stable_branch_patch/Dangerfile:14:in `eval_file'
	from /builds/gitlab-org/gitlab/vendor/ruby/2.7.0/gems/danger-8.6.1/lib/danger/danger_core/dangerfile.rb:311:in `eval'

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports