Related merge requests: Enhance styling
What does this MR do and why?
This MR enhances the styling of Related merge requests to follow the recent changes introduced by Unbox linked widgets (!113820 - merged)
Note: This adds some !important
classes until we change the list styles globally.
Screenshots or screen recordings
Before | After |
---|---|
![]() |
![]() |
![]() |
![]() |
How to set up and validate locally
- Open an Issue with a related merge request
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
changed milestone to %15.10
added UX Paper Cuts groupux paper cuts maintenanceusability sectiondev severity4 typemaintenance + 1 deleted label
assigned to @seggenberger
added UI Unboxing label
Please wait for Reviewer Roulette to suggest a designer for UX review, and then assign them as Reviewer. This helps evenly distribute reviews across UX.
This message was generated automatically. You're welcome to improve it.
1 Warning ⚠ You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the maintenancepipelines, maintenancerefactor, maintenanceworkflow, documentation, QA labels.Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend Stanislav Lashmanov (
@slashmanov
) (UTC+4, 3 hours ahead of@seggenberger
)Jannik Lehmann (
@jannik_lehmann
) (UTC+1, same timezone as@seggenberger
)UX Dan Mizzi-Harris (
@danmh
) (UTC+0, 1 hour behind@seggenberger
)Maintainer review is optional for UX To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
🔁 danger-review
job that generated this comment.Generated by
🚫 Danger- Resolved by Ezekiel Kigbo
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 920b96b8 and 27bb38a5
✨ Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.54 MB 3.54 MB - 0.0 % mainChunk 2.04 MB 2.04 MB - 0.0 %
Note: We do not have exact data for 920b96b8. So we have used data from: 2efb8818.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
🚫 DangerAllure report
allure-report-publisher
generated test report!e2e-review-qa:
❗ test report for 27bb38a5expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Manage | 34 | 0 | 3 | 1 | 37 | ❗ | | Plan | 49 | 0 | 1 | 0 | 50 | ✅ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Govern | 26 | 0 | 5 | 5 | 31 | ❗ | | Verify | 12 | 0 | 0 | 2 | 12 | ❗ | | Create | 28 | 0 | 1 | 0 | 29 | ✅ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | | Framework sanity | 9 | 0 | 1 | 0 | 10 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 162 | 0 | 12 | 8 | 174 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+
mentioned in issue #396430 (closed)
👋 @robyrne
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
- Resolved by Ezekiel Kigbo
Thanks @seggenberger LGTM!
Looks like we're waiting for UX approval, so i'll hold off merging until then :)
Edited by Ezekiel Kigbo
removed review request for @danmh
- Resolved by Sascha Eggenberger
- Resolved by Sascha Eggenberger
Wider thoughts
Here are a few non-blocking thoughts that could consider in follow ups
😊 I'm sure you're aware of all of these- Vertical alignment, is there a way we can make this look optically even at rest? Remove button appears inset because of its padding.
- Status icon alignment, should this be aligned to the centre of the title?
- Tasks, currently use a different pattern, how can we unify these?
- Hover state, I wonder if this pattern makes it feel like the whole row could/should be interactive? Does that matter?
- Vertical alignment, is there a way we can make this look optically even at rest? Remove button appears inset because of its padding.
enabled an automatic merge when the pipeline for 78500e1c succeeds
mentioned in commit bfc595f2
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
mentioned in issue danmh/danmh#17 (closed)
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!1990 (merged)