Context switcher search improvements

changed milestone to %15.10

added Category:Navigation & Settings Deliverable Navigation redesign Next Up Technical Writing UI text UX devopsmanage frontend groupfoundations sectiondev severity3 typefeature workflowin dev + 1 deleted label

assigned to @pgascouvaillancourt

changed title from Draft: [ci skip] Show a loading spinner while searching to Draft: [ci skip] Context switcher search improvements

mentioned in merge request !114491 (merged)

changed the description

added 273 commits

98d72751...fe82cc3a - 270 commits from branch 378541-context-switcher-search
6a121376 - Show a loading spinner while searching
c131da47 - Auto-focus context switcher search input
39397be9 - Show an alert when search fails

Compare with previous version

@aregnery I think we can get started with the UX review here while we wait on !114491 (merged) to be merged. Could you review the three improvements this does and let me know if there's anything we need to change?

requested review from @aregnery

@pgascouvaillancourt here are some areas that need to be cleaned up that I would consider context switcher UI polish

Focus state of the context switcher

We forgot to add a design spec for the focus state. Can we make sure to at least add this in?

Inconsistent :focus across browsers	Proposed :focus state

Nitpick (non-blocking): Color

It looks like avatar icon, title and chevron svg are all #000 but those colors need to be adjusted.

Chevron → gray-400 #89888d
Icon → gray-700 #53518
Title → gray-900 #333238

Lots room for UI polishing (non-blocking)

I noticed we still have lots of small design decisions to update in the context switcher. Question: How would you like to approach polishing towards the proposed design?

Current	Design

added 2 commits

139a73c6 - Adjust context switcher toggle colors
9a0f6233 - Add inset focus style to toggle

Compare with previous version

changed title from Draft: [ci skip] Context switcher search improvements to Draft: Context switcher search improvements

approved this merge request

@aregnery, thanks for approving this merge request.

This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.

For more info, please refer to the following links:

added pipeline:mr-approved label

removed review request for @aregnery

changed the description

added 5 commits

473ec952 - Show a loading spinner while searching
9ec96300 - Auto-focus context switcher search input
675dade2 - Show an alert when search fails
3ba4d037 - Adjust context switcher toggle colors
9ae590bd - Add inset focus style to toggle

Compare with previous version

	1 Warning
	Please add a merge request subtype to this merge request.

1 Message

CHANGELOG missing:

If you want to create a changelog entry for GitLab FOSS, add the Changelog trailer to the commit message you want to add to the changelog.

If you want to create a changelog entry for GitLab EE, also add the EE: true trailer to your commit message.

If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.

Reviewer roulette

Changes that require review have been detected!

Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

Category	Reviewer	Maintainer
frontend	Stanislav Lashmanov (`@slashmanov`) (UTC+4, 8 hours ahead of `@pgascouvaillancourt`)	Tristan Read (`@tristan.read`) (UTC+13, 17 hours ahead of `@pgascouvaillancourt`)
UX	Annabel Dunstone Gray (`@annabeldunstone`) (UTC+0, 4 hours ahead of `@pgascouvaillancourt`)	Maintainer review is optional for UX

To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

@andrei.zubov could you review the frontend please?

requested review from @andrei.zubov

mentioned in issue #378541 (closed)

Allure report

allure-report-publisher generated test report!

e2e-review-qa: test report for 73f93b29

expand test summary

+-----------------------------------------------------------------------+
|                            suites summary                             |
+------------------+--------+--------+---------+-------+-------+--------+
|                  | passed | failed | skipped | flaky | total | result |
+------------------+--------+--------+---------+-------+-------+--------+
| Create           | 28     | 0      | 1       | 0     | 29    | ✅     |
| Manage           | 34     | 0      | 3       | 1     | 37    | ❗     |
| Plan             | 49     | 0      | 1       | 0     | 50    | ✅     |
| Govern           | 26     | 0      | 5       | 5     | 31    | ❗     |
| Package          | 0      | 0      | 1       | 0     | 1     | ➖     |
| Framework sanity | 9      | 0      | 1       | 0     | 10    | ✅     |
| Monitor          | 4      | 0      | 0       | 0     | 4     | ✅     |
| Verify           | 12     | 0      | 0       | 3     | 12    | ❗     |
+------------------+--------+--------+---------+-------+-------+--------+
| Total            | 162    | 0      | 12      | 9     | 174   | ❗     |
+------------------+--------+--------+---------+-------+-------+--------+

deleted the 378541-context-switcher-search branch. This merge request now targets the master branch

added 298 commits

9ae590bd...ee7b6392 - 292 commits from branch master
8ac92ac7 - Show a loading spinner while searching
e723b62c - Auto-focus context switcher search input
4f7402d2 - Show an alert when search fails
01fa2674 - Adjust context switcher toggle colors
c1a01489 - Add inset focus style to toggle
eb1d47bd - Regenerate translations file

Compare with previous version

marked this merge request as ready

Bundle size analysis [beta]

This compares changes in bundle size for entry points between the commits 60df263d and 73f93b29

Special assets

Entrypoint / Name	Size before	Size after	Diff	Diff in percent
average	3.56 MB	3.56 MB	-	0.0 %
mainChunk	2.05 MB	2.05 MB	-	0.0 %

Note: We do not have exact data for 60df263d. So we have used data from: 980bdfe0.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun the bundle-size-review job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.

Please look at the full report for more details

Context switcher search improvements

What does this MR do and why?

Screenshots or screen recordings

How to set up and validate locally

MR acceptance checklist

Activity

Reviewer roulette

Allure report

Bundle size analysis [beta]

Special assets

Context switcher search improvements

What does this MR do and why?

Screenshots or screen recordings

How to set up and validate locally

MR acceptance checklist

Merge request reports

Activity

Reviewer roulette

Allure report

Bundle size analysis [beta]

Special assets